search

jakartaee / persistence

https://jakartaee.github.io/persistence/
Other
187 stars 55 forks source link

Unique constraint creation #388

Open beikov opened 1 year ago

beikov commented 1 year ago

com/sun/ts/tests/jpa/se/schemaGeneration/annotations/index/Client.java#indexTest and com/sun/ts/tests/jpa/se/schemaGeneration/annotations/uniqueConstraint/Client.java#uniqueConstraintTest assume that unique constraints are create as index or through alter table statements, but these could also be created through the create table statement.

beikov commented 1 year ago

Here is the proposed TCK fix for this: https://github.com/jakartaee/platform-tck/pull/1151

scottmarlow commented 1 year ago

Could one of the committers please add the challenge label to this issue.

scottmarlow commented 1 year ago

@lukasj should we back port the https://github.com/jakartaee/platform-tck/pull/1151 change to the Persistence 3.1 TCK? Or exclude the challenged tests?

scottmarlow commented 1 year ago

I'll exclude the challenged tests and stage a Persistence 3.1 TCK for testing. @lukasj, IMO we could later back port the https://github.com/jakartaee/platform-tck/pull/1151 change and release again if you prefer.

scottmarlow commented 1 year ago

https://github.com/scottmarlow/jakartaee-tck/tree/persistence_issues_388 contains the change to be built + tested once we resolve a problem with Docker.