Typesafe operations for controlling find() queries

jakartaee / persistence

https://jakartaee.github.io/persistence/

Other

191 stars 55 forks source link

Typesafe operations for controlling find() queries #415

Closed gavinking closed 12 months ago

gavinking commented 1 year ago

See #383.

Added the Find interface.
Also added a way to set the cache modes for a Query, and the EntityGraph for a TypedQuery.

gavinking commented 12 months ago

This proposal is partially superseded by #436.

However, the operations added to Query and TypedQuery are not in #436. And also perhaps the method naming conventions here are better? (setFoo() vs withFoo())

So we should discuss how to proceed with these two competing PRs.

trajano commented 12 months ago

with... as long as it is fluent

gavinking commented 12 months ago

@trajano The argument against that is that we should keep names consistent across Query and Finder. So I'm uncertain which way to go on this.

trajano commented 12 months ago

I would prefer we mark the non-fluent set methods as deprecated and replace with with if it is fluent. Convention-wise with we expect it to return this whereas set we don't.

gavinking commented 12 months ago

@trajano after discussing with @lukasj last night, we have decided to go in a completely different direction.

trajano commented 11 months ago

Can you link to the different direction @gavinking

gavinking commented 11 months ago

https://github.com/jakartaee/persistence/issues/383#issuecomment-1673920733

https://github.com/jakartaee/persistence/pull/454