search

jakartaee / persistence

https://jakartaee.github.io/persistence/
Other
189 stars 55 forks source link

add joins to entity types (range variables) #467

Closed gavinking closed 10 months ago

gavinking commented 11 months ago

see #128, #71

gavinking commented 11 months ago

Not sure if you want to add/propose the Criteria API changes in a separate PR

OK, so please take a look at the very minimal change I just pushed, and let me know what you think is missing.

Maybe it's fine to say that Join#getAttribute() might return null for entity joins.

That seems completely fine to me.

But I wonder if we should pull getModel() up from Root to From. That's a bit unclear.

beikov commented 11 months ago

But I wonder if we should pull getModel() up from Root to From. That's a bit unclear.

Path, which From extends from, already defines Bindable<X> getModel() I think that's good enough.

gavinking commented 11 months ago

But I wonder if we should pull getModel() up from Root to From. That's a bit unclear.

Path, which From extends from, already defines Bindable<X> getModel() I think that's good enough.

Ah, cool. Missed that. I guess that's fine then.

gavinking commented 10 months ago

@lukasj I have removed all references to right and full joins. Please review. Thanks!