search

jakartaee / persistence

https://jakartaee.github.io/persistence/
Other
187 stars 55 forks source link

Wrong query result type in TCK tests #579

Closed beikov closed 2 months ago

beikov commented 4 months ago

The following two tests use wrong query result types:

They construct a CriteriaQuery with the result type jakarta.persistence.criteria.Expression but select an Employee which is obviously incompatible. Hibernate ORM recently introduced a type assignability validation which now causes an error when executing these TCK tests.

The two tests should be excluded for now and fixed in the next TCK version.

scottmarlow commented 4 months ago

@lukasj do you want to manage this here as a Persistence TCK challenge (needs challenge label) that if accepted, the described tests will be excluded from the Jakarta EE 10 Platform TCK + Persistence 3.1 TCK (e.g. https://download.eclipse.org/jakartaee/persistence/3.1)?

Thanks!

lukasj commented 4 months ago

challenge accepted

...I mean labels added to avoid any confusions :-)

scottmarlow commented 4 months ago

@beikov since this is approved, I'll merge your change to the https://github.com/jakartaee/platform-tck/tree/tckrefactor (for EE 11 currently) and https://github.com/jakartaee/platform-tck/tree/10.0.x branches (for EE 10) Platform TCK branches where we generate the Persistence TCK from.

scottmarlow commented 3 months ago

https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/117 generated the staged Persistence https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-persistence-tck-3.1.3.zip which includes the https://github.com/jakartaee/platform-tck/pull/1246 change.

https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/117/testReport/ shows that the staged Persistence TCK 3.1.3 TCK passed all tests with GlassFish which includes EclipseLink.

https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/118/ also passed with the staged https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-jakartaeetck-10.0.4.zip Platform TCK which has the same fix applied.

CC @beikov

scottmarlow commented 2 months ago

I think that this issue can be closed now

lukasj commented 2 months ago

per the last comment