search

jakartaee / persistence

https://jakartaee.github.io/persistence/
Other
186 stars 55 forks source link

promote jakarta.persistence.database-xxxx config properties #628

Open gavinking opened 1 month ago

gavinking commented 1 month ago

The configuration properties jakarta.persistence.database-product-name, jakarta.persistence.database-major-version, and jakarta.persistence.database-minor-version are currently defined as part of the container/provider contract.

But these properties are generally-useful as a way of configuring the persistence provider when access to JDBC metadata is not available at startup time (for example, in Quarkus, or in some cloud environments). And so Hibernate has never treated them as specific to container-based configuration.

We should promote these to the same status as other application-settable config properties, and add them to PersistenceConfiguration.

quaff commented 1 month ago

Hibernate will use jakarta.persistence.database-xxxx for resolving dialect but EclipseLink will not, the specification only mention them for configuring the schema generation process, I think it should promoted too.

gavinking commented 1 month ago

Yes, exactly, that's what I'm trying to say.