search

jakartaee / platform-tck

Jakartaee-tck
Other
127 stars 108 forks source link

Update EJB Vehicles to EJB 3.x #1269

Closed brideck closed 4 months ago

brideck commented 6 months ago

This takes care of a majority of the failures that occur when EJB 2.x interfaces are removed. Affected buckets include: connector javamail jaxws jdbc jms jta samples webservices12 xa

Note: Some tests will need additional updates to be fully compatible with EJB 3.x. This only takes care of the EJBVehicle itself.

I've done limited testing locally with OL to make sure that the general pattern used here is correct, but don't have any capacity to do a large scale rebuild of all of the affected components of the TCK.

In the event that this testing is ported to Arquillian, etc. these same updates will need to be made in the applications there in order to maintain compatibility with implementations that choose not to support the optional EJB 2.x interfaces.

Needed for https://github.com/jakartaee/platform-tck/issues/1250

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej @starksm64 @scottmarlow

scottmarlow commented 4 months ago

In the event that this testing is ported to Arquillian, etc. these same updates will need to be made in the applications there in order to maintain compatibility with implementations that choose not to support the optional EJB 2.x interfaces.

Thanks for this note Brian, makes sense!

scottmarlow commented 4 months ago

I'm thinking that we should merge your pull requests tomorrow. If further changes are needed after merging, they can be made after.

scottmarlow commented 4 months ago

Thanks Brian!