search

jakartaee / platform-tck

Jakartaee-tck
Other
124 stars 103 forks source link

Address JSTL TCK Challenge tags/issues/255 + tags/issues/256 #1290

Closed scottmarlow closed 3 weeks ago

scottmarlow commented 2 months ago

Address TCK Challenge Issues https://github.com/jakartaee/tags/issues/255 https://github.com/jakartaee/tags/issues/256

This is a fork of https://github.com/jakartaee/platform-tck/pull/1219 change to give us more time to prepare for those changes.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej @starksm64 @scottmarlow

scottmarlow commented 2 months ago

@gurunrao, we should correct the test as agreed in https://github.com/jakartaee/tags/issues/256#issuecomment-2075906928 + https://github.com/jakartaee/tags/issues/256#issuecomment-1997660685

we shouldn't exclude the tests but rather use getCause() rather than getRootCause()

https://github.com/jakartaee/tags/issues/256 Tags 3.0 TCK Challenge for test ExceptionCheckTag.java depending on removed Pages 4.0 JspException.getRootCause() method com/sun/ts/tests/jstl/spec/core/urlresource/importtag/ JSTLClient.java#negativeImportRequestDispatcherServletExceptionTest com/sun/ts/tests/jstl/spec/core/urlresource/importtag/JSTLClient.java#negativeImportRequestDispatcherRTIOExceptionTest com/sun/ts/tests/jstl/spec/fmt/format/fmtnum/JSTLClient.java#negativeFNUnableToParseValueTest com/sun/ts/tests/jstl/spec/fmt/format/parsedate/JSTLClient.java#negativePDUnableToParseValueTest com/sun/ts/tests/jstl/spec/fmt/format/parsenum/JSTLClient.java#negativePNUnableToParseValueTest com/sun/ts/tests/jstl/spec/sql/param/JSTLClient.java#negativeParamQueryBodyContentTest com/sun/ts/tests/jstl/spec/sql/param/JSTLClient.java#negativeParamQuerySQLAttributeTest com/sun/ts/tests/jstl/spec/sql/query/JSTLClient.java#negativeQueryBodyContentTest com/sun/ts/tests/jstl/spec/sql/query/JSTLClient.java#negativeQuerySQLAttributeTest com/sun/ts/tests/jstl/spec/sql/update/JSTLClient.java#negativeUpdateBodyContentTest com/sun/ts/tests/jstl/spec/sql/update/JSTLClient.java#negativeUpdateSQLAttributeTest2

CC @pnicolucci

scottmarlow commented 2 months ago

The Tags team wants to take the risk of making the ^ change. If the change causes further TCK challenge, it may end up being excluded later but that really shouldn't happen.

I point this out as this is the decision to make around whether to exclude or update a TCK test that Spec teams can make. Excluding tests is easy but in this case, it helps keep the current test coverage and make it possible for the tests to work correctly on EE 11.

scottmarlow commented 2 months ago

Note that we need to respond to Paul's question https://github.com/jakartaee/tags/issues/255#issuecomment-2075909065 about whether is time to update the test.