search

jakartaee / platform-tck

Jakartaee-tck
Other
124 stars 103 forks source link

JSTL : Update glassfish runner to fix tests #1303

Closed alwin-joseph closed 1 month ago

alwin-joseph commented 1 month ago

Describe the change

Related PRs:

Pending :

15 test failures with GF8-M5 + JDK21 related to https://github.com/jakartaee/tags/issues/255 due to space character before AM/PM.

com.sun.ts.tests.jstl.compat.onedotzero.JSTLClientIT.positiveFormatLocalizationContextI18NTest com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextI18NTest com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextBrowserLocaleTest com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextBundleTest com.sun.ts.tests.jstl.spec.fmt.format.localecontext.JSTLClientIT.positiveFormatLocalizationContextLocaleTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDBodyValueTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDDateStyleTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDFallbackLocaleTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDLocalizationContextTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDParseLocaleTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeStyleTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeZoneNullEmptyTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeZonePrecedenceTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTimeZoneTest com.sun.ts.tests.jstl.spec.fmt.format.parsedate.JSTLClientIT.positivePDTypeTest

alwin-joseph commented 1 month ago

@scottmarlow @gurunrao Post this change only 15 test failures are there with Glassfish8-M5 + JDK21 which are due to the JDK issue caused with space character before AM/PM.

scottmarlow commented 1 month ago

What does the pr accomplish? Is this fixing the asadmin tool by running in a different Maven phase?

alwin-joseph commented 1 month ago

What does the pr accomplish? Is this fixing the asadmin tool by running in a different Maven phase?

Majorly running the initdb after startdatabase as intended. Basically reordering the plugin executions correctly.

scottmarlow commented 1 month ago

Thanks Alwin!