jakartaee / platform-tck

Jakartaee-tck
Other
127 stars 108 forks source link

Javaee Module : Fix the refactored tests to run with Glassfish 7.0.10+ #1306

Closed alwin-joseph closed 4 months ago

alwin-joseph commented 4 months ago

Describe the change The 24 refactored tests in javaee module was failing with Glassfish 7.0.10+ due to org/slf4j/Logger not found error. The changes replaced the usage of slf4j logger with System.Logger.

Additional context

gurunrao commented 4 months ago

Describe the change The 24 refactored tests in javaee module was failing with Glassfish 7.0.10+ due to org/slf4j/Logger not found error. The changes replaced the usage of slf4j logger with System.Logger.

* The tests pass with 8.0.0-JDK17-M5 + JDK17

* The tests pass with 8.0.0-M5 + JDK21

Additional context

* javaee module tests were refactored in [Javaee Module Refactoring using Arquillian and JUnit #1205](https://github.com/jakartaee/platform-tck/pull/1205) to use Arquillian/Junit.

* Currently the javaee tests uses the servlet module of which the tests were migrated to spec project. In case the servlet module is removed from platform-tck project in future changes, the parts of servlet module which is used by other modules should be retained.

PR https://github.com/jakartaee/platform-tck/pull/1200 is open for removal of servlet TCK. IMO, its good practice to compile using Servlet TCK artifact in classpath, instead of partial retain of the Servlet TCK code within platform TCK repository.