Describe the change
I'm working through the failing sub buckets to update golden files for Java pre and post Java 19. This is a work in progress as I have a couple more sub buckets to work through but I wanted to get a PR up to show progress.
I've decided to leave the original JSPs alone and just create a new set of JSPs and golden files where necessary. This is done where ever we have AM/PM in the actual JSP. If there is no AM/PM in the JSP and we just need to work with the new space character I've just modified the existing JSP to UTF-8 encoding and added a new golden file.
There are more clever ways to do this but I wanted to limit the changes to the existing code base with the intention of this change running on both EE10 and EE11 and being conscious of the fact that these changes are to address a challenge. We can make more clever changes in the future if we have to address a similar problem.
A few additional comments:
positivePDDateStyleTest / positivePDTimeStyleTest / positivePDParseLocaleTest all have an existing goldenfile but the golden file is not used within the JSTLClient for that test so I didn't touch these goldenfiles.
positiveFDTimeZoneNullEmptyTest / positivePDTimeZoneNullEmptyTest were both spelled incorrectly so I fixed the spelling.
If I removed the STANDARD or STANDARD_COMPAT property so that I could override the goldenfiles then I added the TEST_NAME property.
For the new JSPs that were created they are just copies of the original JSP with updates to spacing and formatting.
There are a couple tests that required additional formatting changes from the original in addition to just the space between AM and PM, mainly full date formats in some instance us a , rather than at such as: Friday, December 26, 1997 at 7:11:34 PM Pacific Standard Time in the original and Friday, December 26, 1997, 7:11:34 PM Pacific Standard Time in the updated golden file. These golden files include:
onedotzero\positiveSetTimezoneValueTestJava20Plus.gf
onedotzero\positiveTimezoneValueTestJava20Plus.gf
timezone\positiveTimezoneValueNullEmptyTestJava20Plus.gf
timezone\positiveTimezoneValueTestJava20Plus.gf
settimezone\positiveTimezoneValueNullEmptyTestJava20Plus.gf
settimezone\positiveTimezoneValueTestJava20Plus.gf
Additional context
See the Jakarta Tags Challenge.
Fixes Issue This is for Jakarta Tags Challenge: https://github.com/jakartaee/tags/issues/255
Related Issue(s) https://github.com/jakartaee/tags/issues/255
Describe the change I'm working through the failing sub buckets to update golden files for Java pre and post Java 19. This is a work in progress as I have a couple more sub buckets to work through but I wanted to get a PR up to show progress.
I've decided to leave the original JSPs alone and just create a new set of JSPs and golden files where necessary. This is done where ever we have AM/PM in the actual JSP. If there is no AM/PM in the JSP and we just need to work with the new space character I've just modified the existing JSP to UTF-8 encoding and added a new golden file.
There are more clever ways to do this but I wanted to limit the changes to the existing code base with the intention of this change running on both EE10 and EE11 and being conscious of the fact that these changes are to address a challenge. We can make more clever changes in the future if we have to address a similar problem.
A few additional comments:
JSTLClientfor that test so I didn't touch these goldenfiles.STANDARDorSTANDARD_COMPATproperty so that I could override the goldenfiles then I added theTEST_NAMEproperty.,rather thanatsuch as:Friday, December 26, 1997 at 7:11:34 PM Pacific Standard Timein the original andFriday, December 26, 1997, 7:11:34 PM Pacific Standard Timein the updated golden file. These golden files include: onedotzero\positiveSetTimezoneValueTestJava20Plus.gf onedotzero\positiveTimezoneValueTestJava20Plus.gf timezone\positiveTimezoneValueNullEmptyTestJava20Plus.gf timezone\positiveTimezoneValueTestJava20Plus.gf settimezone\positiveTimezoneValueNullEmptyTestJava20Plus.gf settimezone\positiveTimezoneValueTestJava20Plus.gfAdditional context See the Jakarta Tags Challenge.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej @starksm64 @scottmarlow