search

jakartaee / platform-tck

Jakartaee-tck
Other
124 stars 103 forks source link

Remove getRootCause() #1322

Closed pnicolucci closed 2 weeks ago

pnicolucci commented 4 weeks ago

Fixes Issue https://github.com/jakartaee/tags/issues/256

Related Issue(s) https://github.com/jakartaee/tags/issues/256

Describe the change [JspException.getRootCause()](https://jakarta.ee/specifications/pages/3.1/apidocs/jakarta.servlet.jsp/jakarta/servlet/jsp/jspexception#getRootCause()) has been deprecated and was removed in Pages 4.0 (Jakarta EE11).

For some of the Jakarta Tags tck tests getRootCause was being invoked and causing the following exception: java.lang.NoSuchMethodError: 'java.lang.Throwable jakarta.servlet.jsp.JspException.getRootCause()

Additional context N/A

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej @starksm64 @scottmarlow

pnicolucci commented 4 weeks ago

It looks like this was already fixed in the tckrefactor branch: https://github.com/jakartaee/platform-tck/blob/tckrefactor/jstl/src/main/java/com/sun/ts/tests/jstl/common/tags/ExceptionCheckTag.java#L174C16-L174C56 let me update this PR to be exactly the same code as it is there for consistency

pnicolucci commented 4 weeks ago

Done with updates!

pnicolucci commented 2 weeks ago

@scottmarlow are we good to merge or waiting for others to review?

scottmarlow commented 2 weeks ago

Thank you @pnicolucci!