search

jakartaee / platform-tck

Jakartaee-tck
Other
124 stars 103 forks source link

For discussing whether to create new submodules for component TCKs that we have already released for EE 11 #1344

Open scottmarlow opened 5 days ago

scottmarlow commented 5 days ago

This draft pull request contains some JPA/Persistence test bucket changes (made via OpenRewrite automation). The changes to look at are under https://github.com/jakartaee/platform-tck/commit/5089f06301684b58f1e25a16abfa73d28d1e0c62

When you look at the https://github.com/jakartaee/platform-tck/commit/5089f06301684b58f1e25a16abfa73d28d1e0c62 commit, we should consider whether that is an appropriate change to make to EE TCK projects that have already been released even though we are not actually changing the (already released) JPA/Persistence test classes.

The (jpa) pom.xml version (see https://github.com/jakartaee/platform-tck/pull/1344/files#diff-925f90ce9555617cd3caa9da38987ea95f25366fec7d88b09a63ebc361a84e51) changes from 3.2.0 to 3.2.1-SNAPSHOT don't look right as we already have Persistence 3.2 TCK challenges that call releasing a 3.2.1 Persistence TCK.

This is something that we have discussed recently on https://www.eclipse.org/lists/jakartaee-tck-dev/msg02022.html (see Generating a subclass like this without modifying the existing tests may be what Scott Marlow was talking about on the call on Wednesday.).

In addition to generating a new test class, I'm thinking we should really move the new test classes to a new submodule to have separation between submodules for component TCKs versus Platform TCK tests. I think that this will be important for when we have to release fixes for component TCKs versus releasing fixes for the EE 11 Platform TCK.