search

jakartaee / platform-tck

Jakartaee-tck
Other
126 stars 105 forks source link

Move JSP-related XSD out of TCK project #172

Open kwsutter opened 4 years ago

kwsutter commented 4 years ago

Per the Platform call this morning, it was highlighted that the web-jsptaglibrary_2_1.xsd only resides in this jakartaee-tck repository. Our educated guess is that this is not the proper location. Should it move the JSP repo? Or, the Platform jakartaaee-schemas repo?

https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/lib/schemas/web-jsptaglibrary_2_1.xsd

scottmarlow commented 4 years ago

For reference ReferencesToweb-jsptaglibrary_2_1.xsd.txt contains output from: grep -ri web-jsptaglibrary_2_1.xsd > /tmp/ReferencesToweb-jsptaglibrary_2_1.xsd.txt

It looks like the TCK is using http://java.sun.com/xml/ns/javaee/web-jsptaglibrary_2_1.xsd, although some documentation in lib/schemas/web*.xsd files mention web-jsptaglibrary_2_1.xsd, so perhaps a copy of web-jsptaglibrary_2_1.xsd is in the TCK source for those reading the documentation in .xsd files or as a local copy of the web-jsptaglibrary_2_1.xsd that tests could be changed to use. I'm just guessing.

scottmarlow commented 4 years ago

IMO, based on not seeing anything in the TCK source that would result in (web) hosting the web-jsptaglibrary_2_1.xsd file (as far as I can tell), it should be moved to the Platform jakartaee-schemas repo.

@jansupol do you agree?

kwsutter commented 4 years ago

Looks like @bshannon discovered that this XSD was missed on the initial contribution to Eclipse. He just submitted a CQ to get this schema contributed to the Platform project. Once that's completed, then this Issue can be Closed. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=21868

hussainnm commented 4 years ago

@ivargrimstad Can you check if the CQ 21868 can be approved and checked into jakartaee-schemas.

316

ivargrimstad commented 4 years ago

The CQ is approved for contribution. I have submitted a PR to the Schemas repository for it.

ivargrimstad commented 4 years ago

Next step is to publish it under https://jakarta.ee/xml/ns/jakartaee/. I will do that as soon as the PR has been merged.

scottmarlow commented 4 years ago

Thanks @ivargrimstad!

ivargrimstad commented 4 years ago

The Schema is public: https://jakarta.ee/xml/ns/jakartaee/web-jsptaglibrary_3_0.xsd