search

jakartaee / platform-tck

Jakartaee-tck
Other
126 stars 107 forks source link

Add tests to cover Nonnull and Nullable annotations #944

Open Emily-Jiang opened 2 years ago

Emily-Jiang commented 2 years ago

Apparently no TCK coverage for Nonnull and Nullable defined in Jakarta Common Annotations 1.2. Since there is no TCK for Jakarta Commons, the tcks should be added to the platform tck.

Which subdirectory should the tcks be added?

alwin-joseph commented 2 years ago

Common Annotations TCK (https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/promoted/eftl/jakarta-annotations-tck-2.1.0.zip) only has a signature test https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/signaturetest/caj .

For new tests (non-signature) in Common Annotations to be included in platform TCK , it can be added to a new folder(say caj) at https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests . Also include the path in https://github.com/eclipse-ee4j/jakartaee-tck/blob/e657dfde26a1de85b45a1ab33919e581d8ffe8cc/install/jakartaee/bin/build.xml#L26

@scottmarlow @gurunrao

scottmarlow commented 2 years ago

For new tests (non-signature) in Common Annotations to be included in platform TCK , it can be added to a new folder(say caj) at https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests . Also include the path in

From which EE containers is jakarta.annotation.Nonnull expected to prevent nulls?

From which EE containers is jakarta.annotation.Nullable expected to allow null values?

Do we have an example of another EE 10 SPEC that added a dependency on the jakarta.annotation.Nullable + jakarta.annotation.Nonnull?

Emily-Jiang commented 2 years ago

For new tests (non-signature) in Common Annotations to be included in platform TCK , it can be added to a new folder(say caj) at https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests . Also include the path in

From which EE containers is jakarta.annotation.Nonnull expected to prevent nulls?

yes, based on the javadoc. From which EE containers is jakarta.annotation.Nullable expected to allow null values?

yes, based on the javadoc. Do we have an example of another EE 10 SPEC that added a dependency on the jakarta.annotation.Nullable + jakarta.annotation.Nonnull?

I am not aware of any examples.

scottmarlow commented 2 years ago

For new tests (non-signature) in Common Annotations to be included in platform TCK , it can be added to a new folder(say caj) at https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests . Also include the path in

From which EE containers is jakarta.annotation.Nonnull expected to prevent nulls?

yes, based on the javadoc.

:+1:

From which EE containers is jakarta.annotation.Nullable expected to allow null values?

yes, based on the javadoc.

:+1:

Do we have an example of another EE 10 SPEC that added a dependency on the jakarta.annotation.Nullable + jakarta.annotation.Nonnull?

I am not aware of any examples.

I could not find any references either. So, I think only application deployments will use the Nullable + Nonnull annotations for EE 10.

scottmarlow commented 2 years ago

Which subdirectory should the tcks be added?

I'm not sure yet but it would be good to avoid breaking the Platform TCK test runs at this point, so perhaps adding them to an existing test folder that is easy to update, perhaps https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/javaee/resource/servlet

scottmarlow commented 6 months ago

Note that this issue is for adding tests that deploy to an EE container(s).