search

jakartaee / platform

The Jakarta EE Platform project produces the Jakarta EE platform specification, which is an umbrella specification that aggregates all other Jakarta EE specifications.
https://jakartaee.github.io/platform/
Eclipse Public License 2.0
193 stars 64 forks source link

Searching for types in the EE10 Javadoc leads to a 404 page #613

Closed Azquelt closed 7 months ago

Azquelt commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

When I search for a type in the EE10 Platform Javadoc, the EE10 Web Profile Javadoc or the EE10 Core Profile Javadoc, it takes me to the wrong URL, leading to a 404 page.

To Reproduce Steps to reproduce the behavior:

  1. Go to the EE10 Platform Javadoc
  2. In the search box at the top right, search for CreationalContext
  3. Press Enter, or click on the CreationalContext type
  4. You are taken to https://jakarta.ee/specifications/platform/10/apidocs/undefined/jakarta/enterprise/context/spi/CreationalContext.html, which is not the correct page

Expected behavior A clear and concise description of what you expected to happen.

You should be taken to https://jakarta.ee/specifications/platform/10/apidocs/jakarta/enterprise/context/spi/CreationalContext.html (which then redirects to https://jakarta.ee/specifications/platform/10/apidocs/jakarta/enterprise/context/spi/creationalcontext)

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

This doesn't seem to affect any of the component specifications. I can search for CreationalContext in the CDI 4.0 Javadoc and it takes me to the correct place.

It also doesn't affect searching for packages in the platform Javadoc.

AB#50

ivargrimstad commented 1 year ago

We should make sure this works for Jakarta EE 11

lprimak commented 7 months ago

Checked & Fixed in Jakarta EE 11 (current main branch)

Azquelt commented 7 months ago

Thank you!

OndroMih commented 7 months ago

I'm glad it works for EE 11. But do you really think it's enough to fix it only for EE 11? This should work also for EE 10, even after EE 11 is out. Does anybody know how to fix it for EE 10 too?

lprimak commented 7 months ago

It would require EE 10 patch release

OndroMih commented 7 months ago

That's crazy, really? Can't we do better?

scottmarlow commented 7 months ago

Checked & Fixed in Jakarta EE 11 (current main branch)

Could someone please provide a link to the github commit that contains the fix so we can all better understand what changed to fix the search issue on EE 11. Thanks!

OndroMih commented 7 months ago

OK, I found a quick fix for EE 10, here's a PR: https://github.com/jakartaee/specifications/pull/676

lprimak commented 7 months ago

Good job!