search

jakartaee / platform

The Jakarta EE Platform project produces the Jakarta EE platform specification, which is an umbrella specification that aggregates all other Jakarta EE specifications.
https://jakartaee.github.io/platform/
Eclipse Public License 2.0
193 stars 64 forks source link

[tck-challege] Jakarta EE Core TCK's cdi-lite-tck-suite.xml out of sync with CDI's tck-tests.xml #763

Closed jamezp closed 9 months ago

jamezp commented 9 months ago

Challenged tests There are 3 CDI tests that should be excluded from the Jakarta EE Core TCK's CDI Lite TCK that are not:

TCK Version Jakarta EE Core TCK 10, specifically the CDI TCK 4.0

Description The cdi-lite-tck-suite.xml is out of sync with CDI's tck-tests.xml. These tests should be excluded in the cdi-lite-tck-suite.xml:

<!-- https://github.com/jakartaee/cdi-tck/issues/453 -->
<class name="org.jboss.cdi.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest">
    <methods>
        <exclude name="testCreateReturnsSameBeanPushed"/>
    </methods>
</class>
<class name="org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContextTest">
    <methods>
        <exclude name="testDestroyForSameCreationalContextOnly"/>
    </methods>
</class>

<!-- https://github.com/jakartaee/cdi-tck/issues/485 -->
<class name="org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest">
    <methods>
        <exclude name=".*"/>
    </methods>
</class>

The latter (org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest) causes issues with the TCK passing on Java 21.

I'm not exactly certain on the rules here, but can we exclude the tests via a build configuration? In other words, could a container update its maven-surefire-plugin to explicitly exclude the tests or must the exclusions come from the downloaded TCK itself?

Additional context The CDI TCK Challenge issues:

jamezp commented 9 months ago

Closing this as it should have been filed on the platform-tck project. See https://github.com/jakartaee/platform-tck/issues/1196.