search

jakartaee / rest

Jakarta RESTful Web Services
Other
362 stars 117 forks source link

TCK Migration: Move jaxrs/spec tests from jakartaee-tck #1022

Closed alwin-joseph closed 3 years ago

alwin-joseph commented 3 years ago

This change is in continuation of TCK migration from https://github.com/eclipse-ee4j/jaxrs-api/pull/1002 .

To test the changes :

export JAVA_HOME= export M2_HOME= export PATH=$M2_HOME/bin:$JAVA_HOME/bin:$PATH

jaxrs-tck/ mvn clean install

jersey-tck/ run all tests : mvn clean verify -Parq-glassfish-managed skip optional tests : mvn clean verify -Parq-glassfish-managed -DexcludedGroups="xml_binding"

The tests migrated : jakartaee-tck/src/com/sun/ts/tests/jaxrs/spec(317)

Current status : 1 test failure in jakarta.ws.rs.tck.spec.provider.overridestandard.JAXRSClientIT.readWriteStreamingOutputProviderTest is commented for now. This will be tracked at https://github.com/eclipse-ee4j/jaxrs-api/issues/1020

2 tests are disabled as it was in jakartaee-tck: jakarta.ws.rs.tck.spec.resource.responsemediatype.JAXRSClientIT.noProducesTest jakarta.ws.rs.tck.spec.resource.responsemediatype.JAXRSClientIT.noProducesResponseReturnTest

alwin-joseph commented 3 years ago

@mkarg @andymc12 @spericas @gurunrao

jansupol commented 3 years ago

jakarta.ws.rs.tck.spec.provider.standardhaspriority.JAXRSClientIT.readWriteJaxbProviderTest is a JAX-B test, but JAX-B is optional in 3.1. Same with jakarta.ws.rs.tck.spec.filter.interceptor.JAXRSClientIT.jaxbWriterClientInterceptorTest, jakarta.ws.rs.tck.spec.client.typedentitieswithxmlbinding.JAXRSClientIT.clientJaxbElementReaderTest, jakarta.ws.rs.tck.spec.client.typedentitieswithxmlbinding.JAXRSClientIT.clientJaxbElementWriterTest, and jakarta.ws.rs.tck.spec.provider.standardhaspriority.JAXRSClientIT.readWriteJaxbProviderTest.

alwin-joseph commented 3 years ago

jakarta.ws.rs.tck.spec.provider.standardhaspriority.JAXRSClientIT.readWriteJaxbProviderTest is a JAX-B test, but JAX-B is optional in 3.1. Same with jakarta.ws.rs.tck.spec.filter.interceptor.JAXRSClientIT.jaxbWriterClientInterceptorTest, jakarta.ws.rs.tck.spec.client.typedentitieswithxmlbinding.JAXRSClientIT.clientJaxbElementReaderTest, jakarta.ws.rs.tck.spec.client.typedentitieswithxmlbinding.JAXRSClientIT.clientJaxbElementWriterTest, and jakarta.ws.rs.tck.spec.provider.standardhaspriority.JAXRSClientIT.readWriteJaxbProviderTest.

The optional tests can be excluded by running mvn clean verify -Parq-glassfish-managed -DexcludedGroups="xml_binding"

edit: replaced "optional" with "xml_binding" and tagged more tests as xml_binding as per https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/lib/harness/keyword.properties.

gurunrao commented 3 years ago

run all tests logs : run.log

skip optional tests logs: skip_optional_run.log

alwin-joseph commented 3 years ago

is it possible to squash commits for better readability of repository history?

The PR will be squashed and merged post review as it was done for previous PR with test migration.

jansupol commented 3 years ago

I am pretty sure I tried to squash this, but it did not happen...