search

jakartaee / rest

Jakarta RESTful Web Services
Other
354 stars 114 forks source link

RFC 7231 obsoleted RFC2616: Updating comments on Status enum type #1052

Closed jelemux closed 7 months ago

jelemux commented 2 years ago

RFC 7231 obsoleted RFC 2616. This updates the comments on the Status enum type to refer to current RFCs as requested in #993.

Requesting fast-track review as this PR does neither change the API nor the spec.

mkarg commented 2 years ago

What is the reason for this change?

jansupol commented 2 years ago

This is actually a big change. Up until now, Jakarta REST referred to HTTP 1.1 RFC 2616. This PR basically says RFC 7231 should be used instead. This is fine, but there should be other references to HTTP 1.1 RFC updated, too. For instance, bibliography, reference 4.

mkarg commented 2 years ago

This PR basically says RFC 7231 should be used instead. This is fine, but there should be other references to HTTP 1.1 RFC updated, too. For instance, bibliography, reference 4.

TIL that 7231 obsoleted 2616, so I assume that was @jelemux 's driver for this PR. So I do change the subject and description hereby to indicate this intention.

I agree that we should perform that change eventually, but I doubt it has to be done hastily in 3.1. What do others think?

jansupol commented 2 years ago

Please know that 3.1.0 final is already in staging. I'd defer all enhancements to the next version.

mkarg commented 2 years ago

Please know that 3.1.0 final is already in staging. I'd defer all enhancements to the next version.

You mean 4.0 or or 3.2?

andymc12 commented 2 years ago

I agree with @jansupol - I like the change in general, but agree that it should be deferred to the next release (3.2 if we have one, otherwise 4.0).

mkarg commented 2 years ago

As we are late with 3.1, I think deferring to 4.0 is the right choice.

mkarg commented 2 years ago

@jansupol @spericas @andymc12 @chkal @arjantijms Please review and vote on this PR. Thanks.

mkarg commented 1 year ago

This is actually a big change. Up until now, Jakarta REST referred to HTTP 1.1 RFC 2616. This PR basically says RFC 7231 should be used instead. This is fine, but there should be other references to HTTP 1.1 RFC updated, too. For instance, bibliography, reference 4.

@jelemux Do you like to extend this PR accoringly?

mkarg commented 1 year ago

@jelemux Can you please fix the conflicts? Thanks!

jelemux commented 1 year ago

@jelemux Do you like to extend this PR accoringly?

Yes.

@jelemux Can you please fix the conflicts? Thanks!

And yes, will do.

I'll try to find time for this in the coming week.

spericas commented 7 months ago

Closing as it was never approved