search

jakartaee / rest

Jakarta RESTful Web Services
Other
362 stars 117 forks source link

separate modules into profiles #1062

Closed senivam closed 2 years ago

senivam commented 2 years ago

The purpose of the PR is to separate modules in the parent pom into profiles, which is good for releases to the maven staging/central.

The issue is that when releasing API (from the jaxrs-api module) the parent pom shall be published into staging/central as well.

So, when the forward approach is applied (the project is being built from its root folder) all modules are being compiled. But when it comes to releasing where only particular modules are being released related parent pom becomes invalid from the point of modules view.

In the PR there are 2 profiles with 3 and 1 modules respectively. The module with 3 profiles contains references to API, TCK, and examples. And the module with one module relates to the spec which is never being published to staging/central.

Thus when the project is being compiled from its root folder using mvn clean install the project is being assembled with 3 modules> API, TCK, and examples.

In order to assemble the project with the spec included, the build shall be called in the following way: mvn clean install -Djaxrs.all.build.

Separation of the spec module into an inactive profile guarantees that the parent pom is valid in the maven central without the spec module.

Signed-off-by: Maxim Nesen maxim.nesen@oracle.com

senivam commented 2 years ago

@spericas thank you for the thumb up :) I would like to name the property in a way it shows that it belongs to the concrete project (jaxrs), concrete purpose (build, and not release for example) and that it provides all modules (so all). And it will be better searchable just in case of grep or some regExp. That's only an explanation of my intention :) A simpler name has its advantages as well. So, the name can be changed if my naming is considered too complex.

mkarg commented 2 years ago

I like to remember the developer rules we agreed upon when starting this project: If fast-path is wanted, this has to be claimed in the origin issue description. The reason was that we all, from time to time, will not be able to follow full discussion threads on all issues, and we have a pointer where to focus on. Having said that, I am currently in a situation where I need such pointer. I am not pleased with the recent policy that issues are not marked as fast-track and hastily merged after few days. Please everybody, in particular our project lead, do always actively request fast-track and abstain from fast-track if not requested. Thanks.

spericas commented 2 years ago

I’m making the call to automatically fast track anything that is required to get the release out on time and is not related to API or documentation changes, but just the release process or TCK migration. Without this decision, the release will take months longer to complete.

If you dislike this, please take the time to review the PR’s faster when coming close to a release date.

On Nov 20, 2021, at 3:10 AM, Markus KARG @.**@.>> wrote:

I like to remember the developer rules we agreed upon when starting this project: If fast-path is wanted, this has to be claimed in the origin issue description. The reason was that we all, from time to time, will not be able to follow full discussion threads on all issues, and we have a pointer where to focus on. Having said that, I am currently in a situation where I need such pointer. I am not pleased with the recent policy that issues are not marked as fast-track and hastily merged after few days. Please everybody, in particular our project lead, do always actively request fast-track and abstain from fast-track if not requested. Thanks.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/eclipse-ee4j/jaxrs-api/pull/1062*issuecomment-974613798__;Iw!!ACWV5N9M2RV99hQ!efEhPSgANEL1_vYL_ssyuCmg4UHjDnEs3fzk49VXrwI5JVdW3hehTiqN5sqyrgFfceoRFqwc-w$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABKT2N6EJ22WZ7ZN5H66NH3UM5JY5ANCNFSM5IHP57YA__;!!ACWV5N9M2RV99hQ!efEhPSgANEL1_vYL_ssyuCmg4UHjDnEs3fzk49VXrwI5JVdW3hehTiqN5sqyrgFfcepr0w5bRA$.

mkarg commented 2 years ago

I understand your reasons but that is a violation of the rules we agreed upon. Please stick to the rules unless we agree on new rules. Thanks.

arjantijms commented 2 years ago

Maybe we should reconsider and think about what makes Jakarta REST different from all the other projects in that it's the only project that has this fast-track thing.

mkarg commented 2 years ago

Maybe we should reconsider and think about what makes Jakarta REST different from all the other projects in that it's the only project that has this fast-track thing.

You are free to propose a change of our rules and start a voting among all committers, but please discuss it in the mailinglist, as it is not directly related to this PR. Thanks.