search

jakartaee / rest

Jakarta RESTful Web Services
Other
362 stars 117 forks source link

Allow vendors to add their deployment descriptors to arquillian archives #1064

Closed jansupol closed 2 years ago

jansupol commented 2 years ago

Signed-off-by: jansupol jan.supol@oracle.com

jansupol commented 2 years ago

@scottmarlow @andymc12 This is how the vendor-specific descriptors could be brought into the Arquillian archive. WDYT?

arjantijms commented 2 years ago

@jansupol Arquillian has a standard SPI for what I think you're doing here, it's org.jboss.arquillian.container.test.spi.client.deployment.ApplicationArchiveProcessor

The Arquillian based JWT TCK describes this as well. See: https://github.com/eclipse/microprofile-jwt-auth/blob/master/tck/README.adoc#creating-your-implementation-tck-harness-artifact

jansupol commented 2 years ago

Ok, an alternative approach using ApplicationArchiveProcessor is in #1065.

@arjantijms Thanks for pointing it out.

scottmarlow commented 2 years ago

For the many Platform TCK tests, it would be nice to support something like this pr that allows vendors to specify their folder that contains all of their vendor descriptor files for various test packages. For each test package, we would need to indicate the target archive in some way (whether its a jar, war, ear, rar or whatever) for each contained deployment descriptor.

The ApplicationArchiveProcessor way seems like a group approach as well.

jansupol commented 2 years ago

Closing this in favor of #1065.