jakartaee / rest

Jakarta RESTful Web Services
Other
353 stars 114 forks source link

cleanup javajoe/j2ee users and stop glassfish domain #1080

Closed alwin-joseph closed 2 years ago

alwin-joseph commented 2 years ago

Fixes https://github.com/eclipse-ee4j/jaxrs-api/issues/1079 .

Requesting fast-track review for this one as it changes neither the api nor the spec.

arjantijms commented 2 years ago

Isn't it all easier / better to do this via the Arquillian plug-in and/or enhance that plug-in where needed?

https://github.com/eclipse-ee4j/glassfish/pull/23711/files#diff-d2bcb79be31836aa44619883c498ae598f173cc8e75facd85ae7a489906fad6eR168

e.g.

<dependency>
    <groupId>org.omnifaces.arquillian</groupId>
    <artifactId>arquillian-glassfish-server-managed</artifactId>
    <version>1.0</version>
    <scope>test</scope>
</dependency>

and then:

            <plugin>
                 <artifactId>maven-surefire-plugin</artifactId>
                 <configuration>
                     <systemPropertyVariables>
                         <glassfish.home>${glassfish.home}</glassfish.home>
                         <glassfish.version>${glassfish.version}</glassfish.version>
                         <glassfish.enableDerby>true</glassfish.enableDerby>
                         <glassfish.postBootCommands>
                              create-jdbc-connection-pool --restype javax.sql.DataSource --datasourceclassname org.apache.derby.jdbc.ClientDataSource cts-derby-pool
                              create-jdbc-resource --connectionpoolid cts-derby-pool jdbc/DB1
                         </glassfish.postBootCommands>
                         <tck.home>${tck.home}</tck.home>
                         <!-- Use -Dglassfish.debug=true to debug server part -->
                         <maven.tck.debug>${tck.debug}</maven.tck.debug>
                     </systemPropertyVariables>
mkarg commented 2 years ago

I request fast-path for this PR as it does neither change the API nor the spec. Unfortunately the original author did not request it right from the start.