search

jakartaee / rest

Jakarta RESTful Web Services
Other
353 stars 114 forks source link

TCK Improvement : Use arquillian plugin for executing Glassfish commands #1085

Open alwin-joseph opened 2 years ago

alwin-joseph commented 2 years ago

In jersey-tck/ use arquillian plugin for Glassfish start/stop domain, create/delete users and other commands to be run on glassfish. The same is used for faces prototype tck (in mojarra project). Improve the plugin if required.

Currently we use the below arquillian plugin as glassfish connector.

<dependency>
    <groupId>org.jboss.arquillian.container</groupId>
    <artifactId>arquillian-glassfish-managed-6</artifactId>
    <version>1.0.0.Alpha1</version>
</dependency>

Instead of the above, below jar can be used that has been forked and enhanced from above jar.

<dependency>
    <groupId>org.omnifaces.arquillian</groupId>
    <artifactId>arquillian-glassfish-server-managed</artifactId>
    <version>1.0</version>
    <scope>test</scope>
</dependency>

The relevant comments that discusses the task :

https://github.com/eclipse-ee4j/jaxrs-api/issues/1078#issuecomment-1012188207

https://github.com/eclipse-ee4j/jaxrs-api/pull/1080#issuecomment-1010022818

https://github.com/eclipse-ee4j/jaxrs-api/issues/1079#issuecomment-1008349081

@arjantijms @jelemux

jansupol commented 2 years ago

<glassfish.postBootCommands> looks good. But... if I am not mistaken, GF is restarted for each test/deployment using Arquillian. Is the postBootCommands executed each time the war gets deployed? In Jakarta-REST, we only enable HTTP trace requests, so it can be fast, but we have a couple of hundreds of wars.