search

jakartaee / rest

Jakarta RESTful Web Services
Other
353 stars 114 forks source link

Prepare Jakarta REST release 3.1.1 after updating dependencies #1110

Closed spericas closed 1 year ago

spericas commented 2 years ago

Consider preparing a 3.1.1 release if/when new versions of JAXB and activation are available.

jansupol commented 2 years ago

JAX-B impl is in M4 state. I plan to wait for 4.0.0 Final.

jansupol commented 2 years ago

It is used for the tests, only, though.

spericas commented 2 years ago

@jansupol Do you know if we can update this now?

jamezp commented 2 years ago

The spec does [state](Jakarta® XML Binding, Version 3.0 https://jakarta.ee/specifications/xml-binding/3.0/)

Jakarta® XML Binding, Version 3.0 https://jakarta.ee/specifications/xml-binding/3.0/

However, I see failing platform signature TCK tests due to the jakarta.ws.rs.core.Link$JaxbAdapter. I think it makes sense to require 4.0, but that feels strange in a micro release.

jansupol commented 2 years ago

but that feels strange in a micro release.

What do you mean by micro release? Microprofile is aligned with EE 9, and for microservices, the JAXB should be purely optional.

jansupol commented 2 years ago

The spec does [state](Jakarta® XML Binding, Version 3.0 https://jakarta.ee/specifications/xml-binding/3.0/)

~I could not find it in the spec document. The API already depends on JAX-B 4.0 Final API, Only the test dependency is on 4.0.0-M4. Do we need to release the new API because of the test dependency?~ Sorry, my bad, my local changes in the repo. Indeed dependency for 3.0.

I see failing platform signature TCK tests due to the jakarta.ws.rs.core.Link$JaxbAdapte

~The platform TCK/signature tests are not final, yet. There is still time to update the signature records.~ So now it should fix the signature test, if we have JAX-B 4.0 and the platform has 4.0? Maybe it will break the standalone TCK signature test...

jamezp commented 2 years ago

but that feels strange in a micro release.

What do you mean by micro release? Microprofile is aligned with EE 9, and for microservices, the JAXB should be purely optional.

I just meant it seems weird to migrate to Jakarta XML Binding 4.0 in a 3.1.1 release. A major or minor bump in the version would make more sense in general. However, I understand that is not possible.

jamezp commented 2 years ago

The spec does [state](Jakarta® XML Binding, Version 3.0 https://jakarta.ee/specifications/xml-binding/3.0/)

~I could not find it in the spec document. The API already depends on JAX-B 4.0 Final API, Only the test dependency is on 4.0.0-M4. Do we need to release the new API because of the test dependency?~ Sorry, my bad, my local changes in the repo. Indeed dependency for 3.0.

I see failing platform signature TCK tests due to the jakarta.ws.rs.core.Link$JaxbAdapte

~The platform TCK/signature tests are not final, yet. There is still time to update the signature records.~ So now it should fix the signature test, if we have JAX-B 4.0 and the platform has 4.0? Maybe it will break the standalone TCK signature test...

My apologies. I guess it was a class path issue, so I'm wrong there :) I had a feeling I sent it too soon. It was just the one test failure so I made the bad assumption it had something to do with Jakarta XML Binding.