search

jakartaee / rest

Jakarta RESTful Web Services
Other
361 stars 117 forks source link

Create new test groups - security and servlet #1122

Closed alwin-joseph closed 2 years ago

alwin-joseph commented 2 years ago

Resolves https://github.com/jakartaee/rest/issues/1120 & https://github.com/jakartaee/rest/issues/1121 . Related Issue : https://github.com/eclipse-ee4j/jakartaee-tck/issues/1097

Two new test groups (Junit Tags) are created - "security" & "servlet", so that they can be excluded when run against Core profile.

Requesting fast-track review on this as the changes are involved only in tck. The new service release (3.1.1) of the TCK that will be used for core profile ballot review requires these changes.

cc @jansupol @spericas @starksm64 @brideck

alwin-joseph commented 2 years ago

Can one of the committers please merge this.

starksm64 commented 2 years ago

Is there going to be a new service release with this change?

alwin-joseph commented 2 years ago

Is there going to be a new service release with this change?

The 3.1.1 service release https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-restful-ws-tck-3.1.1.zip is updated with this changes now.

starksm64 commented 2 years ago

Ok, thanks.

brideck commented 2 years ago

Ach, I was off on Friday. This PR missed excluding this class for the "security" group -- https://github.com/jakartaee/rest/blob/master/jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/ee/rs/container/requestcontext/security/JAXRSClientIT.java