search

jakartaee / rest

Jakarta RESTful Web Services
Other
361 stars 117 forks source link

Compiling for Java 21 #1168

Closed mkarg closed 1 year ago

mkarg commented 1 year ago

Fixes #1167

This PR enables compilation of JDK 21 in the release-4.0 branch as proposed in the discussion of https://github.com/jakartaee/rest/issues/1167.

As these are no API changes, this is a fast-track review period of just one day as per our committer rules.

arjantijms commented 1 year ago

Instead of source/target, the release attribute can be used as well.

jamezp commented 1 year ago

Do we want to do this before Java 21 is released?

mkarg commented 1 year ago

Do we want to do this before Java 21 is released?

This happens solely in the release-4.0 branch, where compiling against 21 is mandatory anyways according to the Jakarta EE 11 release plan. JDK 21 published RC 1 already; according to the JDK rules, the sole difference between now and later is more bug fixes. So why should we wait? What would break that could not get fixed within a single business day (and possibly doesn't care as this is not the master branch)?