jakartaee / rest

Jakarta RESTful Web Services
Other
351 stars 114 forks source link

Update the TCK generation , remove old shell script (tckbundle.sh) #1224

Closed alwin-joseph closed 3 months ago

alwin-joseph commented 4 months ago

Describe the changes:

alwin-joseph commented 3 months ago

Needs a PR for main branch as well.

Will it be better to re-target this PR to main branch. I can create another PR for main branch if that is more convenient. In this case, please help merge this PR.

spericas commented 3 months ago

@alwin-joseph I think we should just re-target it to main

alwin-joseph commented 3 months ago

I don't think this question should block the PR and maybe it's been brought up before, but is there any reason we don't simply just generate the TCK docs for each build instead of keeping the generate static content in the source repository?

If you mean the generation of jaxrs-tck/docs/userguide , IMO keeping it separate can reduce the overall build time of other modules(spec, api,tck, examples).

Maybe this can be discussed further if the current build process can be improved.

jamezp commented 3 months ago

I don't think this question should block the PR and maybe it's been brought up before, but is there any reason we don't simply just generate the TCK docs for each build instead of keeping the generate static content in the source repository?

If you mean the generation of jaxrs-tck/docs/userguide , IMO keeping it separate can reduce the overall build time of other modules(spec, api,tck, examples).

Maybe this can be discussed further if the current build process can be improved.

FWIW when I built it locally it didn't take much time at all. I would love to discuss that build process as a whole really as well :)