search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
258 stars 82 forks source link

[TCK Challenge] invalidateHttpSessionxTest #486

Closed mnriem closed 7 months ago

mnriem commented 1 year ago

I have a TCK challenge for the invalidateHttpSessionxTest.

See https://github.com/jakartaee/platform-tck/blob/b23c9554913750a532fd60596b09254a8c7340a0/src/com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#L306

The Piranha project delivers a Servlet container that returns “null” for the ServletContext.getContext(String uripath) which is allowable as per https://jakarta.ee/specifications/servlet/6.0/apidocs/jakarta.servlet/jakarta/servlet/servletcontext#getContext(java.lang.String)

As the test in question assumes that a ServletContext is returned it fails.

arjantijms commented 1 year ago

As far as I remember this was discussed before and indeed said to be an invalid test.

If the null is returned, the test should simply pass.

markt-asf commented 1 year ago

Seems reasonable to me. The test can be excluded for now and we'll fix it for 6.1.

mnriem commented 1 year ago

@markt-asf What is the status of this one?

markt-asf commented 1 year ago

See previous comment.

mnriem commented 8 months ago

@markt-asf Can we close this out?

mnriem commented 7 months ago

@markt-asf Should this be closed out?

stuartwdouglas commented 7 months ago

This has been fixed, so we should close this.