search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
258 stars 82 forks source link

[TCK Challenge] dispatchAfterCommitTest4 #489

Closed mnriem closed 7 months ago

mnriem commented 1 year ago

The com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchAfterCommitTest4 fails, because it is using ServletContext.getContext(path) and in Piranha it returns null (which is allowed) and thus the test fails.

See https://github.com/jakartaee/platform-tck/blob/b23c9554913750a532fd60596b09254a8c7340a0/src/com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/DispatchTestServlet.java#L1079 
for the offending line.

mnriem commented 1 year ago

@markt-asf What is the status of this issue?

markt-asf commented 1 year ago

The test can be excluded for now and we'll fix it for 6.1.

olamy commented 10 months ago

see https://github.com/jakartaee/servlet/pull/553

mnriem commented 8 months ago

@olamy @markt-asf Can I close this one out now?