search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
258 stars 82 forks source link

[TCK Challenge] dispatchAfterCommitTest5 #490

Closed mnriem closed 7 months ago

mnriem commented 1 year ago

I have a TCK challenge for the dispatchAfterCommitTest5.

See https://github.com/jakartaee/platform-tck/blob/b23c9554913750a532fd60596b09254a8c7340a0/src/com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/DispatchTestServlet.java#L1087

The Piranha project delivers a Servlet container that returns “null” for the ServletContext.getContext(String uripath) which is allowable as per https://jakarta.ee/specifications/servlet/6.0/apidocs/jakarta.servlet/jakarta/servlet/servletcontext#getContext(java.lang.String)

As the test in question assumes that a ServletContext is returned it fails.

mnriem commented 1 year ago

@markt-asf What is the status of this issue?

markt-asf commented 1 year ago

The test can be excluded for now and we'll fix it for 6.1.

olamy commented 10 months ago

see https://github.com/jakartaee/servlet/pull/553

mnriem commented 7 months ago

@markt-asf @olamy Can this be closed out?

olamy commented 7 months ago

fixed with #553