Fix #469 - Remove sensitive header on TRACE method

jakartaee / servlet

Jakarta Servlet

https://eclipse.org/ee4j/servlet

Other

258 stars 82 forks source link

Fix #469 - Remove sensitive header on TRACE method #505

Closed dsandrade0 closed 1 year ago

dsandrade0 commented 1 year ago

This commit

dsandrade0 commented 1 year ago

@gregw can you review this code?

markt-asf commented 1 year ago

The review comments have been mostly addressed but I am going to apply this manually so I can make a few tweaks including:

Adding the change to the change log section in the specification
Re-wording the explanation of sensitive headers added to the spec
Generate the default list of headers to exclude once and re-use it
Make header comparison case insensitive
Add Javadoc to isSensitiveHeader()
Rename test methods
Refactor test slightly to avoid NPE warning

markt-asf commented 1 year ago

Greg's comments have been addressed so I am going to dismiss that review as I think not doing so will block the merge of the PR (even doing it manually). If I have missed anything, I'm happy to take an action to get it fixed.

markt-asf commented 1 year ago

Tx. Merged via #519