search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
258 stars 82 forks source link

[Issue 133] Add HTTP PATCH #507

Closed garydgregory closed 1 year ago

garydgregory commented 1 year ago

https://github.com/jakartaee/servlet/issues/113

garydgregory commented 1 year ago

My ECA shows a green checkmark and I've resubmitted, so I'm not sure what " The author(s) of the pull request is not covered by necessary legal agreements in order to proceed." is actually complaining about.

stuartwdouglas commented 1 year ago

With regards to the eca issue does the email used in the commits match the email used to sign the agreement?

garydgregory commented 1 year ago

With regards to the eca issue does the email used in the commits match the email used to sign the agreement?

Well, I thought so but the error message has part of a ".com" email address so maybe my work email got associated with the ECA but I do not see how to change it. I sign in with my gmail address, the account email is my gmail address and I am not allowed to change it to my work email, so I am not sure what to do here... Any advice?

markt-asf commented 1 year ago

Your work email was used for the commits. If you change that to your gmail address and then force push that should fix it.

garydgregory commented 1 year ago

Your work email was used for the commits. If you change that to your gmail address and then force push that should fix it.

Thank you @markt-asf ! Fixed and forced pushed.

I've now removed my -1 brain of farting...

markt-asf commented 1 year ago

I'll merge this shortly. It looks like the update to the formatter is going to impact one of the files changed here. I'll fix that in a separate PR and add the change log entry.

garydgregory commented 1 year ago

I'll merge this shortly. It looks like the update to the formatter is going to impact one of the files changed here. I'll fix that in a separate PR and add the change log entry.

Thanks @markt-asf

garydgregory commented 1 year ago

Hi @markt-asf Could we get a new release published please to pick this up?

markt-asf commented 1 year ago

It is an API change so it will have to wait for Servlet 6.1.

It is available in the Tomcat 11 milestone releases - that includes a Servlet API JAR that includes doPatch. Usual caveats apply about using milestone releases.

garydgregory commented 1 year ago

It is an API change so it will have to wait for Servlet 6.1.

It is available in the Tomcat 11 milestone releases - that includes a Servlet API JAR that includes doPatch. Usual caveats apply about using milestone releases.

@markt-asf,

Thanks for the quick reply Mark.

Any thoughts on when to expect 6.1?

My goal is to push this through Jetty on which we have hard-coded dependencies.

markt-asf commented 1 year ago

Best guess is late this year / early next.