[TCK Challenge] check for object identity in dispatcher test

jakartaee / servlet

Jakarta Servlet

https://eclipse.org/ee4j/servlet

Other

258 stars 82 forks source link

[TCK Challenge] check for object identity in dispatcher test #524

Closed janbartel closed 5 months ago

janbartel commented 1 year ago

Challenged tests:

com/sun/ts/tests/servlet/spec/requestdispatcher/URLClient.requestDispatcherNoWrappingTest

TCK Version:

servlet-tck-6.0.1

Tested Implementation:

Jetty

Description:

Version 6 of the Servlet Spec removed the requirement for object identity during dispatch, see #411. However, the above test is still included in the tck.

markt-asf commented 1 year ago

Looks reasonable to me. I'll leave it a little while to allow others to comment but my expectation at this point is that:

the challenge will be accepted
the test can be added to the ignore list for now
the test will be removed for the Servlet 6.1 TCK

stuartwdouglas commented 1 year ago

Seems reasonable to me.