search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
261 stars 85 forks source link

Refactor tests to use jUnit best practices (from OpenRewrite recipe) #561

Closed lobaorn closed 11 months ago

lobaorn commented 11 months ago

This is the result of applying the recipe using app.moderne.io, in this case, most changes are about removing the "public" modifier since jUnit does not need anymore (as per this PR https://github.com/junit-team/junit5/issues/679).

This is also in alignment with https://github.com/jakartaee/platform-tck/issues/1126, so we can leverage the possibilities of OpenRewrite using the Moderne app for faster iterations in applying the recipes.

I have signed the ECA, and if there are other steps that I have to do, I could not find any applicable in the docs/processes for such a direct/small change.

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.junit5.JUnit5BestPractices

lobaorn commented 11 months ago

As I have addressed through e-mail and on LinkedIn also, this is possible because Tim te Beek of Moderne has enabled the Jakarta repositories there, facilitating applying the recipes (which could be done local, but is much faster and easier through the app.moderne.io interface). I invite you to check @scottmarlow @olamy .

lobaorn commented 11 months ago

Closing, based on the same premise of https://github.com/jakartaee/servlet/pull/562, to later do smaller and localized PRs for each refactoring/enhancement.