search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
253 stars 81 forks source link

Fix #571 - clarify behaviour of Cookie.setAttribute(String, String) #572

Closed markt-asf closed 3 months ago

markt-asf commented 4 months ago

This does change the internal representation of the HttpOnly and Secure attributes but I think it is a change worth making as it provides us with a more generic solution for any similar attributes rather than relying on special handling within the container.

I want to allow time for feedback before merging since there is a behaviour change. But we are also short of time as we need to get the release out this month. I'll leave this as long as I can which probably means ~1 week as I have a bunch of TCK failures I need to work through (most likely configuration issues on my part rather than TCK bugs) and there are the updates / additions to the TCK tests for this release.

volosied commented 3 months ago

@markt-asf Please include this in 6.1, if possible. Thank you