search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
250 stars 79 forks source link

TCK fixes #575

Closed markt-asf closed 4 months ago

markt-asf commented 4 months ago

This PR fixes the following issues I found while trying to build the latest JSP TCK (that depends on the Servlet TCK).

The Servlet API version the TCK depended on needed to be updated to the latest 6.1.0.

One of the tests needed some casts added to resolve the ambiguity between setCharacterEncoding(String) and setCharacterEncoding(Charset).

I think these changes are uncontroversial but since it is the TCK I intend to allow at least 24 hours for review before I merge these changes.

olamy commented 4 months ago

LGTM. But it would be good to have tck artifacts deployed as well. The tag is here, the pom versions have been changed as well but no artifacts available. I'm currently working on removing everything servlet tck related from the main/platform TCK but without the artifacts available it;s not possible (well I can't ask people to rebuild from sources before running TCK :))

markt-asf commented 4 months ago

I'll see about getting an M1 deployed.

olamy commented 4 months ago

I'll see about getting an M1 deployed.

Thanks maybe we should have version number in sync with the API other than that your change in the pom regarding the pom may have issues.

markt-asf commented 4 months ago

The API and the TCK are likely to have divergent point releases. For example if we need to exclude a test from the TCK as the result of a challenge. I should probably revert that change in the POM so they remain independent. I'll update the PR.

markt-asf commented 4 months ago

M1 TCK release is in staging repo. Tagged as 6.1.0-RELEASE-tck. CI system is setup to do snapshot and staging builds. I'm seeing quote a few failures but that could well be configuration issues on my side. I'll open new issues as required as I look into those failures.