TCK updates - cookies - Githubissues

markt-asf commented 3 months ago

This TCK update contains the following changes:

code clean-up to remove all IDE warnings
remove of tests explicitly testing RFC2109 syntax
additional tests to check secure attribute via [g|s]etSecure() [g|s]etAttribute()
new test for cookie values with quotes (RFC 6265 says the quotes are part of the value)
version tests are more explicit that setVersion() is a NO-OP
checks that server doesn't send Max-Age=0
adds check that server sends Expires value in the past for Max-Age=0
new tests for HttpOnly

The tests pass with the current Tomcat 11.0.x development branch although a few minor changes were required to achieve that.

These changes definitely need time for review but we are also up against the deadline for the release. I'll try and wait a full week before merging - assuming there are no objections.

olamy commented 3 months ago

this makes 10 new failures with Jetty 12 ee10. Need to investigate a bit more

markt-asf commented 3 months ago

At a guess it will be the changes to the internal representation for secure and httpOnly along with the clarification that quotes are part of the cookie value. You may need a servlet API build that includes #572

markt-asf commented 3 months ago

@olamy Hi, any update on this? We need to get the Servlet spec to release review by the end of this week and this PR is on the critical path.

olamy commented 3 months ago

All good. I don't have yet a working branch for 6.1.0 spec to easily test with but I'm trusting your changes :)

markt-asf commented 3 months ago

Tx. I'll get this merged later today.

jakartaee / servlet

TCK updates - cookies #583