search

jakartaee / servlet

Jakarta Servlet
https://eclipse.org/ee4j/servlet
Other
250 stars 79 forks source link

tests should not be in the jakarta package #615

Closed lukasj closed 2 days ago

lukasj commented 2 months ago

JESP explicitly prohibits usage of jakarta package namespace to everything but APIs, therefore (unit) tests must be moved to a different package

arjantijms commented 2 months ago

Doesn't the persistence and rest etc TCKS do the same thing?

E.g. rest is "ee.jakarta.tck.ws.rs", persistence is "ee.jakarta.tck.persistence", or do you mean something else?

olamy commented 2 months ago

https://github.com/jakartaee/servlet/tree/master/api/src/test/java/jakarta/servlet are unit tests but those are not distributed. tck is under servlet.tck https://github.com/jakartaee/servlet/tree/master/tck/tck-runtime/src/main/java/servlet/tck

lukasj commented 2 months ago

Doesn't the persistence and rest etc TCKS do the same thing?

E.g. rest is "ee.jakarta.tck.ws.rs", persistence is "ee.jakarta.tck.persistence", or do you mean something else?

jakarta package namespace and ee.jakarta package namespace are different, aren't they?

lukasj commented 2 months ago

JESP 1.4:

Use of the jakarta namespace is limited to API artifacts (all API jars, javadoc, and schema namespaces). It must not be used for any deployment, including applications, TCKs, tools, libraries or any other assets produced by Specification Projects.

so even unit tests which are currently in the jakarta.servlet package need to be in a different package.

olamy commented 2 months ago

JESP 1.4:

Use of the jakarta namespace is limited to API artifacts (all API jars, javadoc, and schema namespaces). It must not be used for any deployment, including applications, TCKs, tools, libraries or any other assets produced by Specification Projects.

Sure but this is still confusing. This is saying It must not be used for any deployment and as I said unit tests not deployed but only part of the source tree.

arjantijms commented 2 months ago

jakarta package namespace and ee.jakarta package namespace are different, aren't they?

I hear you, thanks for the clarification. It's about packages starting with jakarta, and not those containing jakarta somewhere in the middle.