Updates to stage the core profile 11.0.0 release

starksm64 commented 1 month ago

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

[x] A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
[x] Specification PDF in the form of jakarta-wombat-spec-x.y.pdf
[x] Specification HTML in the form of jakarta-wombat-spec-x.y.html
[x] A specification page named _index.md following the template at: https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
[x] N/A For a Progress Review, that sufficient progress has been made on a Compatible Implementation and TCK, to ensure that the spec is implementable and testable.
[x] For a Release Review, a summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification. The TCK users guide MUST include the instructions to run the compatible implementations used to validate the release. Instructions MAY be by reference.
- [x] Updated release record
- [ ] Send an email to the EMO (with cc to the PMC) that contains a link to this PR and a request to the PMC for approval. The EMO will append a checklist to the PR to track the review
[x] The URL of the OSSRH staging repository for the api, javadoc:
- https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/platform/jakarta.jakartaee-core-api/11.0.0/
[x] The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary: https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee11/staged/eftl/jakarta-core-profile-tck-11.0.0.zip SHA256SUM: 5722bac4f1af78e93ede95feaa448aa0bc19934d0871415c25dd45ffa8c5d1a5
[x] The URL of the compatibility certification request issue:
- https://github.com/jakartaee/platform/issues/975
- https://github.com/jakartaee/platform/issues/978
[x] Specification JavaDoc in the wombat/x.y/apidocs directory.
- https://github.com/jakartaee/specifications/pull/785

Note: If any item does not apply, check it and mark N/A below it.

Below are for Jakarta EE Specification Committee

Mentor Spec Review Checklist

Spec PR
- [x] PR uses template
- [x] Directory of form {spec}/x.y
- [x] PDF of form jakarta-{spec}-spec-x.y.pdf ("-spec" preferred but not required)
- [x] HTML of form jakarta-{spec}-spec-x.y.html ("-spec" preferred but not required)
- [x] Index page {spec}/x.y/_index.md following template
- [x] Index page {spec}/_index.md following template
- [x] No other files (e.g., no jakarta_ee_logo_schooner_color_stacked_default.png)
- [x] Staging repository link of the form https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/{spec}/jakarta.{spec}-api/x.y.z/
- [x] EFTL TCK link of the form http://download.eclipse.org/.../+.zip
- [x] Compatibility certification link of the form https://github.com/eclipse-ee4j/{project}/#{issue}
- [x] N/A (Optional) Second PR for just apidocs
_index.md
- [x] Link to project release plan of the form https://projects.eclipse.org/projects/ee4j.{spec}/releases/x.y/plan
- [x] Link to spec pdf
- [x] Link to spec html
- [x] Link to apidocs
- [x] Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip (The folder path is required, the file name pattern is preferred.)
- [x] Link to API jar file of the form https://central.sonatype.com/artifact/jakarta.{spec}/jakarta.{spec}-api/x.y.z/jar
- [ ] Name of and link to at least one Compatible Implementation
- [x] Review summary statement to ensure it has been updated to reflect the work accomplished and does not contain proposal statements as might be found in Plan Review statement.
javadocs
- [x] Footer contains Eclipse copyright and link to license
- [x] ESFL license is included, usually as doc-files/speclicense.html
- [x] no META-INF directory in PR
- [x] javadocs-jar artifact matches apidocs (optional for this release)
Spec PDF
- [x] Correct spec title
- [x] Version number of the form x.y, not x.y.z
- [x] Correct Eclipse copyright line
- [x] Use version 1.1 of the EFSL
- [x] No DRAFT or SNAPSHOT
- [x] Correct Logo
Spec HTML
- [x] Same as PDF
TCK zip file
- [x] README file (optional for this release)
- [ ] EFTL license file, preferably named LICENSE.md
- [x] User's Guide (or equivalent documentation)
- [x] How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
TCK User's Guide (or equivalent documentation)
- [x] Software requirements listed
- [x] Installation and configuration described
- [x] How to run tests
- [x] Where to file challenges
Compatibility certification request
- [x] Request follows template
- [x] SHA-256 fingerprint matches staged TCK zip file
- [x] Request issue has certification label.
TCK results summary
- [x] Page is hosted by Compatible Implementation project
- [x] Includes all information from certification request
- [x] Summary includes number of tests passed, failed, errors
- [x] SHA-256 fingerprint matches staged TCK zip file on cert request
If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org. (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)
- [ ] An issue will be created by the EMO to track the release review.
- [ ] The specification project team requests approval for the release from the PMC by sending an email to ee4j-pmc@eclipse.org.
- [ ] The specification project team then delivers an IP Log to the IP Team for their review as described in https://www.eclipse.org/projects/handbook/#pmi-commands-iplog.
Update Jakarta EE API jar
- [x] N/A Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

Mentor Final Tasks after a Successful Release Review

[ ] adds this final checklist to the main PR.
[ ] adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
[ ] calculates the staged EFTL TCK signature and promotes it to the committee download area using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
[ ] merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
[ ] updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
[ ] notifies the EMO of the ballot results by email to emo@eclipse-foundation.org. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
[ ] creates an issue in the specification project that includes the following checklist for the specification project team: (an example can be found here.)

- [ ] promote api staging release promotes the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript
- [ ] go through the merged jakarta.ee specification website page to verify all the links are valid
- [ ] if XML Schemas are published on https://jakarta.ee/schemas, send a PR to update the status from `Draft` to `Final`
- [ ] approve the compatibility request
- [ ] merge any final release branch as appropriate for the branch management for the project

netlify[bot] commented 1 month ago

Deploy Preview for jakartaee-specifications ready!

Name	Link
Latest commit	4e58ab4bc47b88b90c4b5d40202341d62e6781f4
Latest deploy log	https://app.netlify.com/sites/jakartaee-specifications/deploys/673dedbf18bc320008d2b0bf
Deploy Preview	https://deploy-preview-782--jakartaee-specifications.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

starksm64 commented 1 month ago

The 11.0.0 core proflie tck has been respun and this is the updated bundle info for the staged eftl binary:

***********************************************************************************
***                        TCK bundle information                               ***
*** Name:       jakarta-core-profile-tck-11.0.0.zip                                     ***
*** Bundle Copied to URL:    http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl//jakarta-core-profile-tck-11.0.0.zip ***
*** Date and size: date: 2024-10-31 00:21:40.078183463 +0000, size(b): 170551        ***
*** SHA256SUM: 5722bac4f1af78e93ede95feaa448aa0bc19934d0871415c25dd45ffa8c5d1a5 ***
***                                                                             ***
***********************************************************************************

The maven artifacts are also staged with repository ID jakartatck-1111. https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/tck/coreprofile/core-profile-tck-dist/11.0.0/

Name	Last Modified	Size	Description

ivargrimstad commented 1 month ago

Hi @starksm64,

Here are the core profile specification documents (PDF and HTML) for you to add to the PR. jakarta-coreprofile-spec-11.0.zip

starksm64 commented 3 weeks ago

@ivargrimstad those have been added. It looks like the final apidocs are still needed.

ivargrimstad commented 3 weeks ago

The API docs are in a separate PR.

starksm64 commented 3 weeks ago

Ok, then should be good to go.

Emily-Jiang commented 3 weeks ago

@starksm64 the TCK is missing from the deployed view. Please see the Jakarta Core Profile 10.0 TCK (sig, sha, pub))

Emily-Jiang commented 3 weeks ago

The software requirement was wrong:

A Java SE 11+ runtime

Maven 3.6.x +

Emily-Jiang commented 3 weeks ago

The examples folder wf-core-tck-runner in the tck jar is empty.

tjwatson commented 3 weeks ago

The TCK license is:

Eclipse Foundation Technology Compatibility Kit License - v 1.0

Just double checking that we do not require v 1.1 to be used at https://www.eclipse.org/legal/tck/.

tjwatson commented 3 weeks ago

TCK reference guide section 3.2 has the wrong EE version

3.2. Jakarta EE 10 Runtime Executing the TCK requires a Jakarta EE 10 ...

Emily-Jiang commented 2 weeks ago

@starksm64 please address all of the above comments from me and @tjwatson

starksm64 commented 2 weeks ago

The remaining changes are going to require another respin of the coreprofile tck.

TanjaObradovic commented 2 weeks ago

Thanks @starksm64

ivargrimstad commented 2 weeks ago

Thanks @starksm64! Can you also list the two compatible implementations used for ratification (as is done for Core Profile 10)?

Compatible Implementations used for ratification.
- WildFly
- Open Liberty

starksm64 commented 2 weeks ago

Thanks @starksm64! Can you also list the two compatible implementations used for ratification (as is done for Core Profile 10)?

Compatible Implementations used for ratification.

WildFly

Open Liberty

I added the names, if we want the links to the downloads that will need to be added.

Emily-Jiang commented 2 weeks ago

By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone.

ivargrimstad commented 2 weeks ago

By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone.

Has the TCK been updated again? They both have been respun once.

ivargrimstad commented 2 weeks ago

By the way, after the core profile respin, the existing CCR from Open Liberty and Wildfly need to be redone.

Has the TCK been updated again? They both have been respun once.

Ah, I see it now. The updates to the user guide etc... I'll back the approved label from the CCRs so it Is reflected there

starksm64 commented 2 weeks ago

The 11.0.0 core profile has been respun again and has been staged and uploaded to the project download area. The new info is:

***********************************************************************************
***                        TCK bundle information                               ***
*** Name:       jakarta-core-profile-tck-11.0.0.zip                                     ***
*** Bundle Copied to URL:    http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee11/staged/eftl//jakarta-core-profile-tck-11.0.0.zip ***
*** Date and size: date: 2024-11-14 18:20:10.444442915 +0000, size(b): 224670        ***
*** SHA256SUM: 0357bfab7025972edb2bf50277b6b4206b499a2961bc94e783f34782cc4a9bda ***
***                                                                             ***
***********************************************************************************

The maven artifacts are also staged with repository ID jakartatck-1112. https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/tck/coreprofile/core-profile-tck-dist/11.0.0/

Name	Last Modified	Size	Description

starksm64 commented 2 weeks ago

The TCK license is:

Eclipse Foundation Technology Compatibility Kit License - v 1.0

Just double checking that we do not require v 1.1 to be used at https://www.eclipse.org/legal/tck/.

This was updated to 1.1 since I had to update the TCK anyway

Emily-Jiang commented 2 weeks ago

@starksm64 the complication implementations missed the links

Emily-Jiang commented 2 weeks ago

The software requirement was wrong:

A Java SE 11+ runtime

Maven 3.6.x +

This was not fixed in the readme doc and in the core profile jar. It should be Java SE 17+ runtime in the core profile tck zip. @starksm64

Emily-Jiang commented 2 weeks ago

The software requirement was wrong:

A Java SE 11+ runtime

Maven 3.6.x +

This was not fixed in the readme doc and in the core profile jar. It should be Java SE 17+ runtime in the core profile tck zip. @starksm64

Considering the issue is so minor, I am okay not to do the respin and have this fixed in the next release. If you agree, please go ahead to open an issue to track this in the relevant repo @starksm64

starksm64 commented 2 weeks ago

If you pull down the build tck, which is same as the staged tck, https://ci.eclipse.org/jakartaee-tck/job/11/job/jakarta-core-profile-tck-maven-central/14/artifact/platform-tck/core-profile-tck/tck-dist/target/jakarta-core-profile-tck-11.0.0.zip

this is what the requirements section says in both the core-profile-tck-11.0.0/doc/core-profile-tck-reference-guide.pdf and core-profile-tck-reference-guide.html guides:

3.4. The TCK Environment The TCK requires the following software to be installed: • Java SE 17 or newer • Maven 3.9 or newer • A Jakarta EE 11 implementation (e.g., WildFly 34.x, Open Liberty 24.x)

Are you seeing this somewhere else?

The software requirement was wrong:

A Java SE 11+ runtime

Maven 3.6.x +

This was not fixed in the readme doc and in the core profile jar. It should be Java SE 17+ runtime in the core profile tck zip. @starksm64

Considering the issue is so minor, I am okay not to do the respin and have this fixed in the next release. If you agree, please go ahead to open an issue to track this in the relevant repo @starksm64

Emily-Jiang commented 2 weeks ago

If you pull down the build tck, which is same as the staged tck, https://ci.eclipse.org/jakartaee-tck/job/11/job/jakarta-core-profile-tck-maven-central/14/artifact/platform-tck/core-profile-tck/tck-dist/target/jakarta-core-profile-tck-11.0.0.zip

this is what the requirements section says in both the core-profile-tck-11.0.0/doc/core-profile-tck-reference-guide.pdf and core-profile-tck-reference-guide.html guides:

3.4. The TCK Environment The TCK requires the following software to be installed: • Java SE 17 or newer • Maven 3.9 or newer • A Jakarta EE 11 implementation (e.g., WildFly 34.x, Open Liberty 24.x)

Are you seeing this somewhere else?

The software requirement was wrong:

A Java SE 11+ runtime

Maven 3.6.x +

This was not fixed in the readme doc and in the core profile jar. It should be Java SE 17+ runtime in the core profile tck zip. @starksm64

Considering the issue is so minor, I am okay not to do the respin and have this fixed in the next release. If you agree, please go ahead to open an issue to track this in the relevant repo @starksm64

@starksm64 inside the core-profile-tck-11.0.0.zip, the readme.adoc was not updated. As I mentioned earlier, it is so minor and it can be fixed in the next release.

starksm64 commented 1 week ago

An issue to remove the requirements statements from the readme (where the old ref to Java SE 11 is) has been created: https://github.com/jakartaee/platform-tck/issues/1666

jakartaee / specifications