search

jakartaee / tags

Other
25 stars 28 forks source link

Remove implementation folder; moved to the Eclipse WaSP project. #244

Closed arjantijms closed 1 year ago

arjantijms commented 1 year ago

Fixes https://github.com/eclipse-ee4j/jstl-api/issues/146

Moved to https://github.com/eclipse-ee4j/wasp/tree/master/src/main/java/org/glassfish/wasp/taglibs/standard

Signed-off-by: Arjan Tijms arjan.tijms@omnifish.ee

arjantijms commented 1 year ago

Indeed, they were unit tests, which WaSP isn't already using. I personally think the coverage via integration tests (specifically, the TCK) is much stronger.

With the JPMS, which WaSP should use as well, tests in the same module are a bit questionable (specifically regarding module dependencies, as the jpms doesn't have any concept of a test scope, and test dependencies will therefore be among the required module imports).