search

jakartaee / transactions

Welcome to the Jakarta EE Transactions API Project (formerly JTA)
https://jakartaee.github.io/transactions/
Other
28 stars 29 forks source link

Updated the JTS link to https #178

Closed tomjenkinson closed 3 years ago

tomjenkinson commented 3 years ago

Signed-off-by: Tom Jenkinson tom.jenkinson@redhat.com

tomjenkinson commented 3 years ago

Thanks @LanceAndersen - unfortunately you don't seem to have write access to this repo, I will raise a ticket with Eclipse as you should have (https://projects.eclipse.org/projects/ee4j.jta/who).

[edit: link to ticket https://bugs.eclipse.org/bugs/show_bug.cgi?id=567610]

I can't merge this (GitHub UI doesn't let me) so in the mean time if another project committer arrives here and would be able to review that would be great thanks.

Thanks again!

tomjenkinson commented 3 years ago

@LanceAndersen the Eclipse Webmaster responded on https://bugs.eclipse.org/bugs/show_bug.cgi?id=567610 - it seems there is something that you would need to set on your Eclipse account. I hope if you are able to do that, then your existing review will release the GitHub "Rebase and merge" button for me.

LanceAndersen commented 3 years ago

Hi Tom,

It is set to LanceAndersen (and has been) which is my GitHub username. I assume it does not need to be @LanceAndersen?

On Oct 6, 2020, at 4:48 AM, Tom Jenkinson notifications@github.com wrote:

@LanceAndersen https://github.com/LanceAndersen the Eclipse Webmaster responded on https://bugs.eclipse.org/bugs/show_bug.cgi?id=567610 https://bugs.eclipse.org/bugs/show_bug.cgi?id=567610 - it seems there is something that you would need to set on your Eclipse account. I hope if you are able to do that, then your existing review will release the GitHub "Rebase and merge" button for me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse-ee4j/jta-api/pull/178#issuecomment-704125845, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQPFO7O3BENKRCEGM34JHTSJLKVPANCNFSM4SBZQVFQ.

Best Lance

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com

tomjenkinson commented 3 years ago

I checked mine and it does not have an "@" before tomjenkinson. I will update the ticket that you have it set.

tomjenkinson commented 3 years ago

Sorry, I see you have updated it - thanks!

LanceAndersen commented 3 years ago

I have now totally hosed myself as I inadvertently updated my personal eclipse account to say it was an oracle account vs my oracle eclipse account :-(

I updated the ticket to reflect that and hope the admin can sort this out so I can log in to an account :-(

On Oct 6, 2020, at 6:58 AM, Tom Jenkinson notifications@github.com wrote:

Sorry, I see you have updated it - thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse-ee4j/jta-api/pull/178#issuecomment-704191816, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQPFO6RRGPIUXEWKOGX5HTSJLZ5JANCNFSM4SBZQVFQ.

Best Lance

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com

tomjenkinson commented 3 years ago

Thanks for the update Lance.

I would certainly expect they can fix it up but I am not sure how long it would take so in the meantime I will ask for a second review so that we can get this merged (GitHub won't allow me to merge).

LanceAndersen commented 3 years ago

Hi Tom,

It might be set now. I found a way into my account, removed the GitHub id from my personal eclipse account and added it to my Oracle Eclipse account.

On Oct 6, 2020, at 7:08 AM, Tom Jenkinson notifications@github.com wrote:

Thanks for the update Lance.

I would certainly expect they can fix it up but I am not sure how long it would take so in the meantime I will ask for a second review so that we can get this merged (GitHub won't allow me to merge).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse-ee4j/jta-api/pull/178#issuecomment-704196377, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQPFO7CISTWOIDPDYGHLJTSJL3BPANCNFSM4SBZQVFQ.

tomjenkinson commented 3 years ago

@LanceAndersen - I think your reviews will allow GitHub merges now