search

jakartaee / transactions

Welcome to the Jakarta EE Transactions API Project (formerly JTA)
https://jakartaee.github.io/transactions/
Other
28 stars 29 forks source link

#186: Clean up OSGi manifest headers (without any impact in JavaEE/Ja… #187

Closed grgrzybek closed 3 years ago

grgrzybek commented 3 years ago

…kartaEE aspects)

jta-bot commented 3 years ago

Can one of the admins verify this patch?

tomjenkinson commented 3 years ago

ok to test

grgrzybek commented 3 years ago

btw, I've amended the PR with sign-off and the build failed due to wrong version of parent pom in spec subproject (see https://ci.eclipse.org/jta/job/eclipse-ee4j_jta-api-pulls/242/console):

[FATAL] Non-resolvable parent POM for jakarta.transaction:transactions-spec:1.3: Could not find artifact jakarta.transaction:jakarta.transaction-parent:pom:1.3.3-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 20, column 13

However I don't want to touch the spec module - it is versioned separately and it should point to 1.3.4-SNAPSHOT version of parent pom or the build definition should be changed.

grgrzybek commented 3 years ago

Build failed because of some problems with ... Glassfish build (probably some post JTA API build related to TCK?)

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project tiger-types: Fatal error compiling: invalid target release: 11 -> [Help 1]
tomjenkinson commented 3 years ago

It looks like something to do with JDK11 I think related to Glassfish

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 3 years ago

Seems like master of glassfish requires JDK 11. I found https://github.com/eclipse-ee4j/glassfish/tree/6.0.0-BRANCH which hopefully (a guess though) would be the maintenance branch for Jakarta EE 9

tomjenkinson commented 3 years ago

@grgrzybek please can you raise the PR against master branch? If it's merged then we could look at backports

grgrzybek commented 3 years ago

PR against master: #188

tomjenkinson commented 3 years ago

I will close this PR, the follow-up is here: https://github.com/eclipse-ee4j/jta-api/pull/189