search

jakartaee / transactions

Welcome to the Jakarta EE Transactions API Project (formerly JTA)
https://jakartaee.github.io/transactions/
Other
28 stars 29 forks source link

EE8 OSGI changes Backport #189

Closed tomjenkinson closed 2 years ago

tomjenkinson commented 3 years ago

Jakarta EE 8

Based on https://github.com/eclipse-ee4j/jta-api/pull/187 and using some commits commits (plus changes to resolve merge conflicts) from https://github.com/eclipse-ee4j/jta-api/pull/188

I removed previous the signoff from the commits that I resolved the merge conflicts on and provided with my own

tomjenkinson commented 3 years ago

It seems removing the previous sign-off was a problem so I will rebase again and keep them

tomjenkinson commented 3 years ago

@grgrzybek - please can you take a look?

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 3 years ago

retest this please

grgrzybek commented 3 years ago 
+ cd api
+ mvn -B org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version
+ grep -E ^[0-9]+(\.[0-9]+)+-SNAPSHOT$
+ SNAPSHOT_VERSION=1.3.4-SNAPSHOT
+ cd ..
+ [ 1.3.4-SNAPSHOT = 1.* ]
+ [ 1.3.4-SNAPSHOT = 2.* ]
+ echo Unknown major version
Unknown major version
+ exit -1

I'm not sure what this may be...

tomjenkinson commented 3 years ago

@grgrzybek it's bad scripting on my part :) I am trying to make the PR job work for Jakarta EE 8 and 9

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 3 years ago

retest this please

grgrzybek commented 3 years ago

Build failed with

+ wget -q https://download.eclipse.org/ee4j/jakartaee-tck/8.0.1/promoted/jtatck-1.3_latest.zip -O jtatck.zip
Build step 'Execute shell' marked build as failure
tomjenkinson commented 3 years ago

Thanks! I am going to update the URL in the job config

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 3 years ago

@grgrzybek - the build passed, would you be able to take a look at the backport commits and see if they look OK to you? And I think a thread on jta-dev to discuss the backporting before we do go ahead with this merging the backport too please

grgrzybek commented 3 years ago

@tomjenkinson after some delay, I've sent a message to jta-dev mailing list about possible jakarta.transactiona-api 1.3.4 release as promised. Also, I've checked the commits to be merged to RELEASE-1.3.3 branch and they look fine.

regards Grzegorz Grzybek

tomjenkinson commented 3 years ago

Thanks, both!

tomjenkinson commented 2 years ago

retest this please

tomjenkinson commented 2 years ago

retest this please

tomjenkinson commented 2 years ago

retest this please

tomjenkinson commented 2 years ago

please see my response to https://www.eclipse.org/lists/jta-dev/msg00242.html (it's not cached yet)