jakartaee / transactions

Welcome to the Jakarta EE Transactions API Project (formerly JTA)
https://jakartaee.github.io/transactions/
Other
29 stars 30 forks source link

[#191] using term unchecked exception instead of RuntimeException for rollback for CDI interceptor #192

Open ochaloup opened 3 years ago

ochaloup commented 3 years ago

fixes #191

jta-bot commented 3 years ago

Can one of the admins verify this patch?

tomjenkinson commented 3 years ago

OK to test

tomjenkinson commented 3 years ago

@ochaloup would it result in changes to the TCK? If not, can a TCK test be proposed?

tomjenkinson commented 3 years ago

@ochaloup as you may have seen over at https://www.eclipse.org/lists/jta-dev/msg00198.html I have raised the topic with the community. I would ask, should the change was agreed, would you be willing to create a TCK test that can be used to verify implementations are compliant with the change?

The test would be to:

This might be the place that the test could be added to should the change be agreed: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jta/ee/transactional

ochaloup commented 3 years ago

@tomjenkinson sure, I know. I will try to create the tests in TCK.

tomjenkinson commented 3 years ago

retest this please

tomjenkinson commented 2 years ago

retest this please