Closed starksm64 closed 2 years ago
There is some more information shared here: https://www.eclipse.org/lists/jakartaee-spec-project-leads/msg00780.html
@vanuatoo - I hope I am correct that you are the person who has volunteered in https://www.eclipse.org/lists/jta-dev/msg00206.html to work on this, please can you confirm here?
I confirm
On Mon, Oct 18, 2021, 8:10 PM Tom Jenkinson @.***> wrote:
@vanuatoo https://github.com/vanuatoo - I hope I am correct that you are the person who has volunteered in https://www.eclipse.org/lists/jta-dev/msg00206.html to work on this, please can you confirm here?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse-ee4j/jta-api/issues/194#issuecomment-945933700, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPG6ZSR5NPTRFUYHM4NZZTUHRBFRANCNFSM5FP2T4SQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Great - thank you, I will go ahead and assign you.
API depends on two modules: CDI and Interceptors
If I just put
requires jakarta.cdi; requires jakarta.interceptor.api;
Everything builds fine, but maven complains about automodules
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ jakarta.transaction-api ---
[WARNING] *********************************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [jakarta.interceptor-api-2.0.0.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] *********************************************************************************************************************************************************
If I put as it should be by the instructions
requires jakarta.interceptors;
maven fails to build
How should I proceed?
Ok, you will need proper releases of jakarta.interceptors and jarkarta.cdi. I'll post when those are available.
@vanuatoo Ok, so there are now releases of jakarta.interceptors version=2.0.1-RC1 and jakarta.cdi version = 4.0.0.Beta3 released to maven central that have module-info in the api artifact. Retry with these versions.
The correct release versions are now: jakarta.interceptor-api = 2.1.0-RC3 jakarta.enterprise.cdi-api = 4.0.0-RC3
2.0.1 is currently referencing CDI 3.0.1 is that correct and final? I am trying to match up for Jakarta Connectors. When I upgrade the dependency to Jakarta Transactions 2.0.1 it required me to add Jakarta CDI as a provided dependency in order to compile.
This was the PR where we updated to 3.0.1: https://github.com/jakartaee/transactions/pull/199/files
If we want to update to a later version that will hopefully be OK. If that is the case, please can I ask for an issue (and hopefully a PR) to be raised to track the work in? I could create a new service release 2.0.2 for Jakarta Transactions.
BTW I am going to close this issue as we have the 2.0.1 with module-info but we can keep the conversation going on CDI.
A requirement for the EE10 release is for API jars to include a proper module-info.class. Please create a service release to include this.
eclipse-ee4j/jakartaee-platform#421