jakartaee / transactions

Welcome to the Jakarta EE Transactions API Project (formerly JTA)
https://jakartaee.github.io/transactions/
Other
29 stars 30 forks source link

Bump jakarta.enterprise.cdi-api to the final 3.0.0 #196

Closed pzygielo closed 2 years ago

jta-bot commented 2 years ago

Can one of the admins verify this patch?

tomjenkinson commented 2 years ago

ok to test

pzygielo commented 2 years ago

Build failed for external reason:

+ GLASSFISH_BRANCH=6.0.0-BRANCH
+ TCK_VERSION=https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/jakarta-transactions-tck-2.0.0.zip
+ GLASSFISH_MAJOR=6
+ TS_JTE=https://raw.githubusercontent.com/eclipse-ee4j/jakartaee-tck/master/install/jta/bin/ts.jte
+ git clone https://github.com/eclipse-ee4j/glassfish.git
...
+ cd glassfish
+ git checkout 6.0.0-BRANCH
error: pathspec '6.0.0-BRANCH' did not match any file(s) known to git
Build step 'Execute shell' marked build as failure
...
Finished: FAILURE

Jenkins job needs to be updated I guess.

tomjenkinson commented 2 years ago

I think you are right, I will set the job to use master for Glassfish branch for our master branch.

As a note, the reason I think we should use master from their branches is that in their README.md it says Eclipse GlassFish 7.0.0 is Jakarta EE 10 compatible, requires Java 11, supports Java 18 and we are working towards EE 10 here and https://github.com/eclipse-ee4j/glassfish/commit/0ed4fff8b6d07cba46e4ba8904a29a2a2f86e985 does not seem to be in any other tag or branch at the moment so if we want to try to work with EE10 Glassfish I don't think there is much to try with. That said, if we have some difficulty I suppose we could try to fix our testing on https://github.com/eclipse-ee4j/glassfish/tree/6.2.3 given that "Eclipse GlassFish 6.2.0 is Jakarta EE 9.1 compatible, requires Java 11, supports Java 17"

tomjenkinson commented 2 years ago

retest this please

pzygielo commented 2 years ago

Eclipse GlassFish 7.0.0 is Jakarta EE 10 compatible, requires Java 11, supports Java 18

Right. While Jenkins here seems to use 8:

[eclipse-ee4j_jta-api-pulls] $ /opt/tools/java/oracle/jdk-8/latest/bin/java 

However with JDK 11 something like

is required here, otherwise:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  27.034 s
[INFO] Finished at: 2021-12-06T18:46:55+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.9:javadoc (default) on project jakarta.transaction-api: An error has occurred in JavaDocs report generation: 
[ERROR] Exit code: 1 - .../jta-api/api/src/main/java/jakarta/transaction/package.html:31: error: self-closing element not allowed
[ERROR] <br/>
[ERROR] ^
[ERROR] .../jta-api/api/src/main/java/jakarta/transaction/package.html:34: warning: empty <p> tag
[ERROR] <p>
[ERROR] ^
[ERROR] .../jta-api/api/src/main/java/jakarta/transaction/Transactional.java:68: warning: no @return
[ERROR]     TxType value() default TxType.REQUIRED;
[ERROR]            ^
[ERROR] 
[ERROR] Command line was: javadoc @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '.../jta-api/api/target/site/apidocs' dir.
tomjenkinson commented 2 years ago

Once I have confirmed that platform EE 10 requires 11 (and not say, Glassfish) I will update this job to use JDK 11. Thank you for raising the topic.

starksm64 commented 2 years ago

The correct version of CDI for EE10 is 4.0.0. There is a 4.0.0-RC3 that is the expected final API binary.

starksm64 commented 2 years ago

Included in #199. My previous comment was incorrect as we want to only do a service release and not update the dependencies to new major versions.

tomjenkinson commented 2 years ago

Thank you for the contribution @pzygielo I will close this out as we have the PR https://github.com/eclipse-ee4j/jta-api/pull/199 which has a later version (3.0.1)