jakartaee / validation-spec

Jakarta Validation spec document
http://beanvalidation.org
Apache License 2.0
20 stars 22 forks source link

Compatibility certification request for Hibernate Validator #246

Closed gunnarmorling closed 5 years ago

gunnarmorling commented 5 years ago
bshannon commented 5 years ago
gunnarmorling commented 5 years ago

the TCK results summary both says it's running the 2.0.2

Thanks, good catch. Fixed.

and the 2.0.4.Final version of the TCK

The 2.0.4 here is the previous version of the API signature file. The test run is set up to validate the BV 2.0.2 API against those signatures (representing the BV 2.0.1 API, i.e. last version under the Java EE umbrella) in order to make sure that there are no changes whatsoever to the actual API signatures.

As for the test suite execution, this is running the 2.0.5 TCK tests against HV 6.0.17.

bshannon commented 5 years ago

That's very confusing or misleading. Shouldn't the API signature test version match the TCK version, or perhaps the spec version?

As far as I can tell the last version of the spec approved by the JCP was "2.0", not "2.0.1". And of course the version of the Jakarta Bean Validation spec is "2.0".

gunnarmorling commented 5 years ago

@bshannon, re-ran the TCK and the signature check against the signature from the 2.0.5 TCK, updated the linked certification log accordingly and also addressed your other remarks regarding links above.

From my PoV, nothing remains to be done from my side apart from adding "certification label" which I still can't do due to lack of permissions (see the discussion on the spec lead mailing list).

starksm64 commented 5 years ago

Verified SHA256: Scotts-iMacPro:BV starksm$ shasum -a 256 beanvalidation-tck-dist-2.0.5.tar.gz 5710e607b1939c54753320d25cb885811ff9b68a51c168c1a0bd37768c9a0a97 beanvalidation-tck-dist-2.0.5.tar.gz

gunnarmorling commented 5 years ago

Updated the SHA checksums above as per today's re-release of the TCK tar.gz and zip files (due to doc updates solely).

gunnarmorling commented 5 years ago

Updated the SHA checksums above as per today's re-release of the TCK tar.gz and zip files. Also re-ran Hibernate Validator 6.0.17.Final against that new TCK release and updated the linked logs of the certification run.

edbratt commented 5 years ago

Is this okay to close? (it's been marked accepted.)