jakartaee / validation-tck

Jakarta Validation TCK
http://validator.hibernate.org
Apache License 2.0
38 stars 33 forks source link

BVTCK 12 #1

Closed hferentschik closed 13 years ago

hferentschik commented 13 years ago

Needs to be pulled in for aligning the TCK tests regarding Path.Node with the specification

mbenson commented 13 years ago

Hi, Hardy. After having muddled my way through git pull to be able to see the changes in context, I still don't think this is quite right. Take, for example, PropertyPathTest.testPropertyPathWithMap(). It is my understanding that the actual property path to which the constraint violation refers is "actors[1].lastName". Per my reading of the spec that would be:

rather than the structure here of:

Thanks, Matt

hferentschik commented 13 years ago

I know. Emmanuel already pointed it out to me. Not sure what I was thinking. I will create a new pull request.

hferentschik commented 13 years ago

I don't seem to be able to display the latest changes on my BKTCK-12 branch, but you can view them here - https://github.com/hferentschik/beanvalidation-tck/commit/cb4c9278cd44cc67ef54663e29bfc4bd85b815fe

hferentschik commented 13 years ago

Hmm, maybe it's a caching issue - http://support.github.com/discussions/pull-requests/39-pull-request-page-says-branch-is-up-to-date-when-it-isnt I will try to update the pull request later again