search

jakartaee / validation-tck

Jakarta Validation TCK
http://validator.hibernate.org
Apache License 2.0
38 stars 33 forks source link

Make sure that there are no encoded symbols in the jar file paths #198

Closed marko-bekhta closed 5 months ago

marko-bekhta commented 6 months ago

Hey @starksm64 ,

I was looking into problems running a TCK on CI after some unrelated upgrades, and noticed that using code source location can result in a path like:

file:/var/lib/jenkins/workspace/hibernate-validator_PR-1347%40tmp/maven-repository/org/assertj/assertj-core/3.8.0/assertj-core-3.8.0.jar

where @ is encoded (%40) and which results in this file being not found. The suggested change to call toURI should address the encoding/decoding issue.

gsmet commented 6 months ago

@starksm64 I'm not sure what the process is nowadays so I didn't merge it but this looks good to me and would unblock some Hibernate Validator work if you could get something released.

Thanks!

yrodiere commented 5 months ago

Hey @starksm64,

Bump?

@starksm64 I'm not sure what the process is nowadays so I didn't merge it but this looks good to me and would unblock some Hibernate Validator work if you could get something released.

Thanks!

starksm64 commented 5 months ago

So do you need a service release of the TCK?

marko-bekhta commented 5 months ago

Hey,

So do you need a service release of the TCK?

yes, that would be nice. if we get this patch released then we'd be able to move forward with the Hibernate Validator work. Thanks!

Emily-Jiang commented 4 months ago

@marko-bekhta we discussed at the platform call today for requesting a service release to take this PR in. In order to do a service release, a challenge is need. Can you raise an issue here with the tag of Challenge? Once it is created and accepted, a service release can be done.

marko-bekhta commented 4 months ago

Hey @Emily-Jiang I've created https://github.com/jakartaee/validation-spec/issues/284. I cannot add labels to the created issue though... Let me know if there's anything else needed to move this forward. Thanks!

starksm64 commented 4 months ago

Nothing else required, I'll release the 3.1.1 service today

marko-bekhta commented 4 months ago

Thanks a lot!

Emily-Jiang commented 4 months ago

Thank you @marko-bekhta @starksm64 !