search

jakartaee / validation-tck

Jakarta Validation TCK
http://validator.hibernate.org
Apache License 2.0
38 stars 33 forks source link

BVTCK-28, BVTCK-31 - Updating TCK to match current section structure, adding assertions for 1.1 #7

Closed gunnarmorling closed 11 years ago

hferentschik commented 11 years ago

In your latest commit 485ad1a you basically started marking sentences related to BV 1.1 as testable in the spec right. When you then recreated the audit file you needed to adjust the labeling in the existing tests. I checked a couple of them and it looks fine. Just wondering how you find out which one to change? Did you just look at the TCK coverage report and should the report now not contain uncovered assertions?

hferentschik commented 11 years ago

should the report now not contain uncovered assertions?

ahh, it does. Needed to rebuild.

gunnarmorling commented 11 years ago

Just wondering how you find out which one to change?

I went through the coverage report and manually checked for changes. It's not perfect, but I applied the changes chapter-wise, so it was still managable.

Emmanuel and I also discussed about having the sentence "numbers" automatically generated instead of using "a", "b" ..., e.g. using a hash code of the sentences, concatenating the first letter of each word or similar. This would be robust against newly inserted assertions but would complicate things if wording within an existing assertion changes. Thus we decided to go with what we currently have.

Actually I'm quite happy with it, adding the assertions for BV 1.1 went really fast, so I think the effort for the generation has already paid off.

gunnarmorling commented 11 years ago

should the report now not contain uncovered assertions?

ahh, it does. Needed to rebuild.

Yeah, I'm right now in the process of adding the required tests. If you feel like writing one or two, just let me know :)

hferentschik commented 11 years ago

Actually I'm quite happy with it, adding the assertions for BV 1.1 went really fast, so I think the effort for the generation has already paid off.

cool

gunnarmorling commented 11 years ago

Now we only need a way to generate the actual tests :)