jakartaee / validation-tck

Jakarta Validation TCK
http://validator.hibernate.org
Apache License 2.0
38 stars 33 forks source link

BVTCK-82 Convert the documentation to Asciidoctor #82

Closed gsmet closed 7 years ago

gsmet commented 7 years ago
gunnarmorling commented 7 years ago

@gsmet nice, that looks very good overall. Just two remarks:

gsmet commented 7 years ago

Can we bring back numbering for sections and the ToC?

Sorry about that. Fixed.

The Duke looks a bit lost up there; how about putting him between the title and "Preface", making him larger, too.

Done.

Force pushed an update, everything should be OK now.

gunnarmorling commented 7 years ago

Merged, all looking good now. Added one more commit to pin two plug-in versions. Thanks, @gsmet!